Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MC-34456: Related Products can not be added to the Shopping Cart from a Wish List #32275

Merged
merged 2 commits into from
Mar 8, 2021
Merged

MC-34456: Related Products can not be added to the Shopping Cart from a Wish List #32275

merged 2 commits into from
Mar 8, 2021

Conversation

SmVladyslav
Copy link
Contributor

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Related Products can not be added to the Shopping Cart from a Wish List #32274

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 24, 2021

Hi @SmVladyslav. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Feb 24, 2021
@SmVladyslav
Copy link
Contributor Author

@magento run all tests

@shikhamis11 shikhamis11 self-requested a review February 25, 2021 06:03
@shikhamis11
Copy link
Member

@magento run all tests

@ankurvr
Copy link
Member

ankurvr commented Feb 25, 2021

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @ankurvr. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @ankurvr, here is your Magento Instance: https://52f1b8ebccb17f953892b26244a96c3f-2-4-develop.instances.magento-community.engineering
Admin access: https://52f1b8ebccb17f953892b26244a96c3f-2-4-develop.instances.magento-community.engineering/admin_da5f
Login: 22550b35
Password: 758754df43e5

@SmVladyslav
Copy link
Contributor Author

@magento run Functional Tests CE

@SmVladyslav
Copy link
Contributor Author

@magento run Functional Tests EE

@m2-community-project m2-community-project bot moved this from Pending Review to Ready for Testing in High Priority Pull Requests Dashboard Feb 25, 2021
@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11, thank you for the review.
ENGCOM-8816 has been created to process this Pull Request
✳️ @shikhamis11, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@shikhamis11 shikhamis11 added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix labels Feb 25, 2021
@dmitriyprime
Copy link
Contributor

@magento I am working on this

@dmitriyprime
Copy link
Contributor

✔️ QA passed

Before:
before

After:
after

@zakdma
Copy link
Contributor

zakdma commented Mar 3, 2021

@magento import code to https://github.com/magento-tsg/magento2ce

@magento-engcom-team
Copy link
Contributor

@zakdma, an error occurred during the Pull Request import.

1 similar comment
@magento-engcom-team
Copy link
Contributor

@zakdma, an error occurred during the Pull Request import.

@zakdma
Copy link
Contributor

zakdma commented Mar 3, 2021

@magento import code to https://github.com/magento-tsg/magento2ce

@magento-engcom-team
Copy link
Contributor

@zakdma the branch with code successfully imported intomagento-tsg/magento2ce repository. Branch name: imported-magento-magento2-32275.

@magento-engcom-team magento-engcom-team merged commit bff13d9 into magento:2.4-develop Mar 8, 2021
@m2-assistant
Copy link

m2-assistant bot commented Mar 8, 2021

Hi @SmVladyslav, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@engcom-Foxtrot engcom-Foxtrot moved this from Ready for Testing to Recently Merged in High Priority Pull Requests Dashboard Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakdma zakdma zakdma approved these changes

@shikhamis11 shikhamis11 shikhamis11 approved these changes

Assignees

@zakdma zakdma

@shikhamis11 shikhamis11

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Wishlist Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Related Products can not be added to the Shopping Cart from a Wish List
6 participants
@SmVladyslav @shikhamis11 @ankurvr @magento-engcom-team @dmitriyprime @zakdma