Skip to content

Feature: added confirm before updating the attribute set #32914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from
Open

Feature: added confirm before updating the attribute set #32914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Set/Main.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,13 @@ protected function _prepareLayout()
);
}

$message = __("Warning: removing an attribute from the set result in the loss of that attribute data in the set. This is without making a backup first not recoverable");
$this->getToolbar()->addChild(
'save_button',
\Magento\Backend\Block\Widget\Button::class,
[
'label' => __('Save'),
'onclick' => 'editSet.save();',
'onclick' => "if ( true == confirm('{$message}')) { editSet.save();}",
'class' => 'save primary save-attribute-set'
]
);
Expand Down