MFTF: Newsletter Subscription With Enabled Need To Confirm Config #33342

DmitryTsymbal · 2021-06-24T13:12:43Z

This PR contains a MFTF test for checking newsletter subscription process with enabled "Need To Confirm" config.
Guests and customers should receive correct notifications.

Steps to reproduce
1 - Enable "Need To Confirm" config.
2 - Subscribe to newsletter as guest on storefront
3 - Login as customer
4 - Subscribe to newsletter as customer on storefront
5 - Perform assertions

Resolved issues:

resolves [Issue] MFTF: Newsletter Subscription With Enabled Need To Confirm Config #33344: MFTF: Newsletter Subscription With Enabled Need To Confirm Config

m2-assistant · 2021-06-24T13:12:45Z

Hi @DmitryTsymbal. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

DmitryTsymbal · 2021-06-24T13:12:54Z

@magento run all tests

magento-automated-testing · 2021-06-24T13:13:01Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

shikhamis11 · 2021-06-24T15:38:25Z

@magento create issue

shikhamis11 · 2021-06-26T07:22:15Z

@magento run all tests

magento-automated-testing · 2021-06-26T07:22:22Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

shikhamis11 · 2021-07-29T15:19:00Z

@magento run Sample Data Tests EE, Sample Data Tests CE, Sample Data Tests B2B, Functional Tests EE, Functional Tests CE, Functional Tests B2B

magento-automated-testing · 2021-07-29T15:19:09Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

shikhamis11 · 2021-08-15T18:40:25Z

@magento run all tests

magento-automated-testing · 2021-08-15T18:40:33Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

sidolov · 2021-10-14T19:02:32Z

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B

magento-automated-testing · 2021-10-14T19:03:04Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

sidolov

@DmitryTsymbal please, check failed tests

DmitryTsymbal · 2021-10-19T09:19:45Z

@magento run all tests

magento-automated-testing · 2021-10-19T09:19:53Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2021-10-27T13:25:22Z

Hi @DmitryTsymbal,

Thank you for your contribution!

I am looking into the build failures.

Thank you!

…eed-to-confirm

engcom-Charlie · 2021-11-02T10:27:00Z

@magento run all tests

magento-automated-testing · 2021-11-02T10:27:08Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2021-11-03T05:49:26Z

@magento run all tests

magento-automated-testing · 2021-11-03T05:49:34Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

…eed-to-confirm

engcom-Charlie · 2021-11-09T11:05:43Z

@magento run all tests

magento-automated-testing · 2021-11-09T11:05:47Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

… rename StoreFront to Storefront

engcom-Charlie · 2021-11-10T12:13:54Z

@magento run all tests

magento-automated-testing · 2021-11-10T12:14:01Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2021-11-11T11:12:04Z

@magento run Functional Tests EE

magento-automated-testing · 2021-11-11T11:12:12Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2021-11-11T13:46:23Z

Hi @sidolov,

I have merged 2.4 develop into this branch and also fixed the issue of failed StorefrontNewsletterSubscriptionWithEnabledNeedToConfirmConfigTest functional test case.

As the PR is covering the MFTF test case and now the build is green so moving it forward to Merge in Progress.

Thank you!

engcom-Charlie · 2022-03-10T12:42:23Z

It seems that bot moved this PR in Changes Requested, so moving it back to Merge in Progress.

Thank you!

…rm Config #33342

Newsletter Subscription With Enabled Need To Confirm Config

ba526b6

magento-engcom-team added Component: Newsletter Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jun 24, 2021

shikhamis11 self-requested a review June 24, 2021 15:37

m2-assistant bot mentioned this pull request Jun 24, 2021

[Issue] MFTF: Newsletter Subscription With Enabled Need To Confirm Config #33344

Closed

m2-community-project bot added the Progress: pending review label Jun 24, 2021

shikhamis11 added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jul 29, 2021

Merge branch '2.4-develop' into newsletter-need-to-confirm

9a26e69

Merge branch '2.4-develop' into newsletter-need-to-confirm

48446f8

sidolov requested changes Oct 15, 2021

View reviewed changes

m2-community-project bot assigned sidolov Oct 15, 2021

m2-community-project bot added Progress: needs update and removed Progress: pending review labels Oct 15, 2021

engcom-Charlie self-assigned this Oct 29, 2021

Merge remote-tracking branch 'magento2/2.4-develop' into newsletter-n…

a8e9f66

…eed-to-confirm

Merge remote-tracking branch 'magento2/2.4-develop' into newsletter-n…

8f5a2fa

…eed-to-confirm

33342-Fixed the issue of build failure where in changed the title and…

c3b21b2

… rename StoreFront to Storefront

m2-community-project bot added Progress: accept and removed Progress: needs update labels Nov 11, 2021

m2-community-project bot added Progress: needs update and removed Progress: accept labels Mar 10, 2022

m2-community-project bot added Progress: accept and removed Progress: needs update labels Mar 10, 2022

magento-devops-reposync-svc pushed a commit that referenced this pull request Apr 5, 2022

ENGCOM-9341: MFTF: Newsletter Subscription With Enabled Need To Confi…

d06055b

…rm Config #33342

magento-devops-reposync-svc merged commit 9829ce7 into magento:2.4-develop Apr 5, 2022

MFTF: Newsletter Subscription With Enabled Need To Confirm Config #33342

MFTF: Newsletter Subscription With Enabled Need To Confirm Config #33342

Uh oh!

Conversation

DmitryTsymbal commented Jun 24, 2021 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Resolved issues:

Uh oh!

m2-assistant bot commented Jun 24, 2021

Uh oh!

DmitryTsymbal commented Jun 24, 2021

Uh oh!

magento-automated-testing bot commented Jun 24, 2021

Uh oh!

shikhamis11 commented Jun 24, 2021

Uh oh!

shikhamis11 commented Jun 26, 2021

Uh oh!

magento-automated-testing bot commented Jun 26, 2021

Uh oh!

shikhamis11 commented Jul 29, 2021

Uh oh!

magento-automated-testing bot commented Jul 29, 2021

Uh oh!

shikhamis11 commented Aug 15, 2021

Uh oh!

magento-automated-testing bot commented Aug 15, 2021

Uh oh!

sidolov commented Oct 14, 2021

Uh oh!

magento-automated-testing bot commented Oct 14, 2021

Uh oh!

sidolov left a comment

Choose a reason for hiding this comment

Uh oh!

DmitryTsymbal commented Oct 19, 2021

Uh oh!

magento-automated-testing bot commented Oct 19, 2021

Uh oh!

engcom-Charlie commented Oct 27, 2021

Uh oh!

engcom-Charlie commented Nov 2, 2021

Uh oh!

magento-automated-testing bot commented Nov 2, 2021

Uh oh!

engcom-Charlie commented Nov 3, 2021

Uh oh!

magento-automated-testing bot commented Nov 3, 2021

Uh oh!

engcom-Charlie commented Nov 9, 2021

Uh oh!

magento-automated-testing bot commented Nov 9, 2021

Uh oh!

engcom-Charlie commented Nov 10, 2021

Uh oh!

magento-automated-testing bot commented Nov 10, 2021

Uh oh!

engcom-Charlie commented Nov 11, 2021

Uh oh!

magento-automated-testing bot commented Nov 11, 2021

Uh oh!

engcom-Charlie commented Nov 11, 2021

Uh oh!

engcom-Charlie commented Mar 10, 2022

Uh oh!

Uh oh!

DmitryTsymbal commented Jun 24, 2021 •

edited by m2-assistant bot

Loading