Skip to content

Conversation

texboy
Copy link
Contributor

@texboy texboy commented Jul 1, 2021

Description (*)

Update the colinmollenhour/credis package from 1.11.1 to 1.12.1

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/556

Fixed Issues (if relevant)

  1. Fixes Update colinmollenhour/credis to the latest version #32870

Questions or comments

Following the steps provided on the issue, this is the information that I was able to gather:

  • The "colinmollenhour/php-redis-session-abstract" depends on the module.
  • The "colinmollenhour/cache-backend-redis" also uses a the credis module but does not depend on it directly.
    - The php file "Creds/Client.php" is required inside the "vendor/colinmollenhour/cache-backend-redis/stats.php" file.
    - the "Credis_Client" class is used inside "vendor/colinmollenhour/cache-backend-redis/Cm/Cache/Backend/Redis.php"
    - The "Credis_Client" class is used inside the "vendor/colinmollenhour/php-redis-session-abstract/src/Cm/RedisSession/Handler.php" class
  • The module does not have a migration guide. https://github.com/colinmollenhour/credis/releases

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jul 1, 2021

Hi @texboy. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me platform-health instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jul 1, 2021
@magento-engcom-team magento-engcom-team added Partner: Webjump partners-contribution Pull Request is created by Magento Partner labels Jul 1, 2021
@texboy
Copy link
Contributor Author

texboy commented Jul 1, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev ihor-sviziev self-assigned this Jul 2, 2021
@ihor-sviziev ihor-sviziev added Progress: pending review Project: Platform Health Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. and removed Progress: review labels Jul 2, 2021
@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B, Unit Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jul 2, 2021
@sivaschenko sivaschenko merged commit 8ba3f89 into magento:platform-health Jul 2, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jul 2, 2021

Hi @texboy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: Webjump partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing Project: Platform Health Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants