33378 GraphQL: create an entry in 'customer_log' after generate customer token #33409

khrystynastolbova · 2021-07-02T14:51:38Z

Description (*)

Create an entry in 'customer_log' after generate customer token.

Related Pull Requests

Fixed Issues (if relevant)

Fixes Logging in or out as customer via graphql doesnt create a entry in 'customer_log' #33378

Manual testing scenarios (*)

Check 'customer_log' db table
Genarate customer token

mutation {
	generateCustomerToken(
        email: "roni_cost@example.com"
        password: "roni_cost3@example.com"
    ) {
        token
    }
}

Check 'customer_log' db table again. The field 'last_login_at' for this customer was updated.

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

…er token

m2-assistant · 2021-07-02T14:51:40Z

Hi @khrystynastolbova. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

ihor-sviziev · 2021-07-05T05:32:11Z

@magento run all tests

magento-automated-testing · 2021-07-05T05:32:17Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

eduard13

Thank you @khrystynastolbova for fixing this one. Could you please review the minor suggestions below?

eduard13 · 2021-07-05T05:41:47Z

dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/LoggerTest.php

+     *
+     * @var Logger
+     */
+    protected $logger;


Suggested change

protected $logger;

private $logger;

eduard13 · 2021-07-05T05:43:04Z

app/code/Magento/CustomerGraphQl/etc/graphql/events.xml

+ * See COPYING.txt for license details.
+ */
+-->
+<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Event/etc/events.xsd">


Suggested change

<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Event/etc/events.xsd">

<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"

xsi:noNamespaceSchemaLocation="urn:magento:framework:Event/etc/events.xsd">

eduard13 · 2021-07-05T05:43:40Z

dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/LoggerTest.php

+     * @param string $password
+     * @return string
+     */
+    private function getQuery(string $email = 'customer@example.com', string $password = 'password') : string


Suggested change

private function getQuery(string $email = 'customer@example.com', string $password = 'password') : string

private function getQuery(string $email = 'customer@example.com', string $password = 'password'): string

ihor-sviziev

Here is one more improvement

dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/LoggerTest.php

khrystynastolbova · 2021-07-05T09:28:28Z

@ihor-sviziev and @eduard13, Thanks for your review and suggestions! I will make changes.
Maybe it would be better to move the logger test to GenerateCustomerTokenTest.php file and there add tearDown function to remove the customer log record? Because this test is failing

…an code

khrystynastolbova · 2021-07-05T12:08:52Z

Please check my recent changes

khrystynastolbova · 2021-07-05T12:09:10Z

@magento run all tests

magento-automated-testing · 2021-07-05T12:09:18Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-12-29T07:06:41Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-12-29T14:18:32Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Lima · 2021-12-30T05:55:52Z

@magento run Functional Tests CE

magento-automated-testing · 2021-12-30T05:56:00Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Lima · 2021-12-30T07:17:12Z

@magento run Functional Tests CE

magento-automated-testing · 2021-12-30T07:17:20Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Lima · 2021-12-30T09:04:39Z

@magento run Functional Tests CE

magento-automated-testing · 2021-12-30T09:04:47Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Lima · 2021-12-30T10:25:18Z

@magento run Functional Tests CE

magento-automated-testing · 2021-12-30T10:25:26Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Lima · 2021-12-30T12:34:54Z

Hi @eduard13 the tests are now passed, moving this PR to Pending Review

eduard13

Looks good for me 👍
Thanks for your input @khrystynastolbova

magento-engcom-team · 2021-12-30T17:26:37Z

Hi @eduard13, thank you for the review.
ENGCOM-9157 has been created to process this Pull Request

engcom-Alfa · 2022-01-04T08:52:58Z

✔️ QA Passed

Preconditions:

Have a Magento lastest instance installed
Have one customer created for front end login as well

Manual testing scenario:

Make a note of customer last login time from customer_log DB table (Customer id can be found in the customer_entity table under entity_id column).
Do get the customer token with GraphQL request
Re validate the customer last login is updated in the DB table.

Before: ✖️ The last_login_at column data was not getting updated to the latest GraphQL login

After: ✔️ The last_login_at column data was is getting updated to the latest GraphQL login

There is already a regression au-test has bee updated along with the PR changes, and hence no additional regression is required.

ishakhsuvarov · 2022-06-10T14:22:30Z

@magento run all tests

magento-automated-testing · 2022-06-10T14:22:36Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

vishaljpatil · 2022-10-31T14:30:47Z

Hello @khrystynastolbova,

Can you please let us know about updating "last_logout_at" on customer revoke token using graphql (revokeCustomerToken).

On revoke token customer log table "last_logout_at" column not updating.

… of magento 2.4.x magento/magento2#33409

33378 GraphQL: create a entry in 'customer_log' after generate custom…

7e00080

…er token

m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jul 2, 2021

magento-engcom-team added Component: CustomerGraphQl Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jul 2, 2021

m2-community-project bot added Progress: pending review labels Jul 2, 2021

ihor-sviziev added Award: bug fix Award: test coverage labels Jul 5, 2021

ihor-sviziev self-assigned this Jul 5, 2021

m2-community-project bot added Progress: pending review Progress: review and removed Progress: pending review labels Jul 5, 2021

ihor-sviziev added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jul 5, 2021

m2-community-project bot removed the Progress: pending review label Jul 5, 2021

eduard13 requested changes Jul 5, 2021

View reviewed changes

m2-community-project bot assigned eduard13 Jul 5, 2021

m2-community-project bot added Progress: needs update and removed Progress: review labels Jul 5, 2021

ihor-sviziev requested changes Jul 5, 2021

View reviewed changes

dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/LoggerTest.php Outdated Show resolved Hide resolved

33378 GraphQL: move logger test to GenerateCustomerTokenTest.php; cle…

07f5212

…an code

m2-community-project bot added Progress: pending review and removed Progress: needs update labels Dec 30, 2021

eduard13 approved these changes Dec 30, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: pending review labels Dec 30, 2021

engcom-Alfa self-assigned this Jan 4, 2022

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Jan 4, 2022

m2-community-project bot added Progress: accept and removed Progress: testing in progress labels Jan 4, 2022

Merge branch '2.4-develop' into 33378_graphQL_customer_log

9fdbc70

magento-devops-reposync-svc merged commit c020ed2 into magento:2.4-develop Jun 11, 2022

freezy-sk added a commit to freezy-sk/magento-module-customer-graph-ql-extended that referenced this pull request Mar 7, 2023

added customer_login event observer until it will be released as part…

2d06444

… of magento 2.4.x magento/magento2#33409

freezy-sk mentioned this pull request Mar 7, 2023

added customer_login event observer storefront-x/magento-module-customer-graph-ql-extended#11

Merged

	<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Event/etc/events.xsd">
	<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
	xsi:noNamespaceSchemaLocation="urn:magento:framework:Event/etc/events.xsd">

	private function getQuery(string $email = 'customer@example.com', string $password = 'password') : string
	private function getQuery(string $email = 'customer@example.com', string $password = 'password'): string

33378 GraphQL: create an entry in 'customer_log' after generate customer token #33409

33378 GraphQL: create an entry in 'customer_log' after generate customer token #33409

Uh oh!

Conversation

khrystynastolbova commented Jul 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Jul 2, 2021

Uh oh!

ihor-sviziev commented Jul 5, 2021

Uh oh!

magento-automated-testing bot commented Jul 5, 2021

Uh oh!

eduard13 left a comment

Choose a reason for hiding this comment

Uh oh!

eduard13 Jul 5, 2021

Choose a reason for hiding this comment

Uh oh!

eduard13 Jul 5, 2021

Choose a reason for hiding this comment

Uh oh!

eduard13 Jul 5, 2021

Choose a reason for hiding this comment

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

khrystynastolbova commented Jul 5, 2021

Uh oh!

khrystynastolbova commented Jul 5, 2021

Uh oh!

khrystynastolbova commented Jul 5, 2021

Uh oh!

magento-automated-testing bot commented Jul 5, 2021

Uh oh!

magento-automated-testing bot commented Dec 29, 2021

Uh oh!

magento-automated-testing bot commented Dec 29, 2021

Uh oh!

engcom-Lima commented Dec 30, 2021

Uh oh!

magento-automated-testing bot commented Dec 30, 2021

Uh oh!

engcom-Lima commented Dec 30, 2021

Uh oh!

magento-automated-testing bot commented Dec 30, 2021

Uh oh!

engcom-Lima commented Dec 30, 2021

Uh oh!

magento-automated-testing bot commented Dec 30, 2021

Uh oh!

engcom-Lima commented Dec 30, 2021

Uh oh!

magento-automated-testing bot commented Dec 30, 2021

Uh oh!

engcom-Lima commented Dec 30, 2021

Uh oh!

eduard13 left a comment

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Dec 30, 2021

Uh oh!

engcom-Alfa commented Jan 4, 2022

Uh oh!

ishakhsuvarov commented Jun 10, 2022

Uh oh!

magento-automated-testing bot commented Jun 10, 2022

Uh oh!

vishaljpatil commented Oct 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

khrystynastolbova commented Jul 2, 2021 •

edited

Loading

vishaljpatil commented Oct 31, 2022 •

edited

Loading