33194: Update Swagger UI to 3.51.1 version and configure security definitions #33427

mmezhensky · 2021-07-06T13:32:44Z

Description (*)

Updating Swagger UI to last version 3.51.1

Fixed Issues (if relevant)

Fixes Swagger UI is out of date (version 3 is latest) #33194

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

…initions

m2-assistant · 2021-07-06T13:32:46Z

Hi @mmezhensky. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

andrewbess · 2021-07-06T13:35:31Z

@magento run Unit Tests

magento-automated-testing · 2021-07-06T13:35:37Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mmezhensky · 2021-07-06T17:53:25Z

@magento run Unit Tests

magento-automated-testing · 2021-07-06T17:53:33Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

hostep · 2021-07-06T18:34:30Z

Hi @mmezhensky

Could you rename the 2 new javascript files (swagger-ui-es-bundle.js & swagger-ui-es-bundle-core.js) and use .min.js in their filenames?

It appears these two files are already minified. When using .min.js as filenames it will prevent Magento from trying to minify them again during the static content deploy phase.

We already needed to do this in the past explicitly for the swagger js files to fix an issue with the minifier.

Thanks!

magento-automated-testing · 2021-07-06T18:44:17Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mmezhensky · 2021-07-06T18:47:41Z

@hostep
I added these changes.
Thank you so much for being so helpful.

mmezhensky · 2021-07-06T19:29:44Z

@magento run all tests

magento-automated-testing · 2021-07-06T19:29:52Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

mmezhensky · 2021-07-07T09:21:00Z

@magento run all tests

magento-automated-testing · 2021-07-07T09:21:05Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-07-08T06:53:44Z

@magento run WebAPI Tests

magento-automated-testing · 2021-07-08T06:53:51Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-07-08T08:13:07Z

@magento run all tests

magento-automated-testing · 2021-07-08T08:13:15Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-07-08T11:49:24Z

@magento run all tests

magento-automated-testing · 2021-07-08T11:49:27Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-07-14T09:33:41Z

@magento run all tests

magento-engcom-team · 2021-07-14T09:47:46Z

Hi @andrewbess, thank you for the review.
ENGCOM-9145 has been created to process this Pull Request
✳️ @andrewbess, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

andrewbess · 2021-07-14T16:22:39Z

@magento run all tests

magento-automated-testing · 2021-07-14T16:22:43Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-07-14T18:40:04Z

@magento run WebAPI Tests

magento-automated-testing · 2021-07-14T18:40:09Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess · 2021-07-14T20:19:06Z

@magento run Functional Tests B2B

magento-automated-testing · 2021-07-14T20:19:11Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik · 2021-07-15T10:22:47Z

@magento run Functional Tests B2B

magento-automated-testing · 2021-07-15T10:22:52Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-engcom-team · 2021-07-15T10:23:33Z

Hi @Den4ik, thank you for the review.
ENGCOM-9145 has been created to process this Pull Request

m2-assistant · 2021-07-19T11:03:38Z

Hi @mmezhensky, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

33194: Update Swagger UI to 3.51.1 version and configure security def…

80513e4

…initions

m2-community-project bot added the Progress: pending review label Jul 6, 2021

andrewbess self-requested a review July 6, 2021 13:35

andrewbess self-assigned this Jul 6, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Jul 6, 2021

33194: Fix unit tests

4978098

33194: Adjust name for a new js files

ccd1799

33194: Fix static test and remove es-bundle files

454de9c

Fixes for magento-swagger.js according to Magento JSCS rules

7623e8a

andrewbess force-pushed the 33194-upgrade-swagger-ui branch from 4f19537 to 7623e8a Compare July 8, 2021 11:48

andrewbess added the Award: MFTF test coverage label Jul 14, 2021

andrewbess added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jul 14, 2021

hostep mentioned this pull request Jul 14, 2021

32855: upgrade to the latest moment-timezone-with-data.js #33476

Merged

5 tasks

CE-33194: Added MFTF tests

e528f41

andrewbess force-pushed the 33194-upgrade-swagger-ui branch from 7d8c870 to e528f41 Compare July 14, 2021 16:17

Merge branch '2.4-develop' into 33194-upgrade-swagger-ui

cdc5173

andrewbess added the Award: category of expertise label Jul 14, 2021

Den4ik approved these changes Jul 15, 2021

View reviewed changes

m2-community-project bot assigned Den4ik Jul 15, 2021

magento-engcom-team added Area: Frontend Component: Swagger Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" labels Jul 15, 2021

sivaschenko changed the base branch from 2.4-develop to platform-health July 15, 2021 13:42

sivaschenko changed the base branch from platform-health to 2.4-develop July 15, 2021 13:42

sivaschenko changed the base branch from 2.4-develop to platform-health July 16, 2021 09:22

sivaschenko changed the base branch from platform-health to 2.4-develop July 16, 2021 09:22

sivaschenko changed the base branch from 2.4-develop to platform-health July 16, 2021 17:30

andrewbess merged commit f123109 into magento:platform-health Jul 19, 2021

hostep mentioned this pull request Aug 4, 2021

Update underscore to latest version #33609

Merged

5 tasks

33194: Update Swagger UI to 3.51.1 version and configure security definitions #33427

33194: Update Swagger UI to 3.51.1 version and configure security definitions #33427

Uh oh!

Conversation

mmezhensky commented Jul 6, 2021

Description (*)

Fixed Issues (if relevant)

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Jul 6, 2021

Uh oh!

andrewbess commented Jul 6, 2021

Uh oh!

magento-automated-testing bot commented Jul 6, 2021

Uh oh!

mmezhensky commented Jul 6, 2021

Uh oh!

magento-automated-testing bot commented Jul 6, 2021

Uh oh!

hostep commented Jul 6, 2021

Uh oh!

magento-automated-testing bot commented Jul 6, 2021

Uh oh!

mmezhensky commented Jul 6, 2021

Uh oh!

mmezhensky commented Jul 6, 2021

Uh oh!

magento-automated-testing bot commented Jul 6, 2021

Uh oh!

mmezhensky commented Jul 7, 2021

Uh oh!

magento-automated-testing bot commented Jul 7, 2021

Uh oh!

andrewbess commented Jul 8, 2021

Uh oh!

magento-automated-testing bot commented Jul 8, 2021

Uh oh!

andrewbess commented Jul 8, 2021

Uh oh!

magento-automated-testing bot commented Jul 8, 2021

Uh oh!

andrewbess commented Jul 8, 2021

Uh oh!

magento-automated-testing bot commented Jul 8, 2021

Uh oh!

andrewbess commented Jul 14, 2021

Uh oh!

magento-engcom-team commented Jul 14, 2021

Uh oh!

andrewbess commented Jul 14, 2021

Uh oh!

magento-automated-testing bot commented Jul 14, 2021

Uh oh!

andrewbess commented Jul 14, 2021

Uh oh!

magento-automated-testing bot commented Jul 14, 2021

Uh oh!

andrewbess commented Jul 14, 2021

Uh oh!

magento-automated-testing bot commented Jul 14, 2021

Uh oh!

Den4ik commented Jul 15, 2021

Uh oh!

magento-automated-testing bot commented Jul 15, 2021

Uh oh!

magento-engcom-team commented Jul 15, 2021

Uh oh!

m2-assistant bot commented Jul 19, 2021

Uh oh!

Uh oh!