Skip to content

33511: Updated phpmd/phpmd composer dependency to version 2.9.1 #33524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 22, 2021
Merged

33511: Updated phpmd/phpmd composer dependency to version 2.9.1 #33524

merged 3 commits into from
Jul 22, 2021

Conversation

anzin
Copy link
Contributor

@anzin anzin commented Jul 19, 2021

Description (*)

I've updated phpmd/phpmd composer dependency to version 2.9.1

Fixed Issues (if relevant)

  1. Fixes Update phpmd/phpmd composer dependency to version 2.9.1 #33511

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jul 19, 2021

Hi @anzin. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me platform-health instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jul 19, 2021
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jul 19, 2021
@anzin
Copy link
Contributor Author

anzin commented Jul 19, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik Den4ik self-requested a review July 19, 2021 13:07
@Den4ik Den4ik self-assigned this Jul 19, 2021
@anzin
Copy link
Contributor Author

anzin commented Jul 19, 2021

@magento run WebAPI Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@eduard13 eduard13 self-assigned this Jul 20, 2021
@eduard13 eduard13 added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Project: Platform Health labels Jul 20, 2021
eduard13
eduard13 reviewed Jul 20, 2021
View reviewed changes
Den4ik
Den4ik approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@Den4ik Den4ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved.
Thanks for contribution

@eduard13
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@anzin
Copy link
Contributor Author

anzin commented Jul 20, 2021

@magento run WebAPI Tests, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@anzin anzin force-pushed the improvement/m2-33511-update-phpmd-composer-dependency branch from 17d1be3 to 4081703 Compare July 21, 2021 13:06
@anzin
Merge branch 'platform-health' into improvement/m2-33511-update-phpmd…
32d599b 
…-composer-dependency

# Conflicts:
#	composer.lock
@anzin anzin force-pushed the improvement/m2-33511-update-phpmd-composer-dependency branch from 4081703 to 32d599b Compare July 21, 2021 13:09
@anzin
Copy link
Contributor Author

anzin commented Jul 21, 2021

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@anzin
Copy link
Contributor Author

anzin commented Jul 21, 2021

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess
andrewbess approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@andrewbess andrewbess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @anzin
Your changes look good for me.
Thank you for your job

Den4ik
Den4ik approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@Den4ik Den4ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved.
@anzin Thanks for work

@andrewbess andrewbess merged commit 2f64daa into magento:platform-health Jul 22, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jul 22, 2021

Hi @anzin, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

2 similar comments
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Den4ik Den4ik Den4ik approved these changes

@andrewbess andrewbess andrewbess approved these changes

@eduard13 eduard13 eduard13 approved these changes

Assignees

@Den4ik Den4ik

@andrewbess andrewbess

@eduard13 eduard13

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing Project: Platform Health
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anzin @eduard13 @Den4ik @andrewbess @magento-engcom-team