Skip to content

#33510: updated magento/composer version #33546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 25, 2021
Merged

#33510: updated magento/composer version #33546

merged 4 commits into from
Jul 25, 2021

Conversation

korovitskyi
Copy link
Collaborator

@korovitskyi korovitskyi commented Jul 21, 2021 •
edited by andrewbess
Loading

Description (*)

Updated magento/composer version.
Reopen by #33521.

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/564

Fixed Issues (if relevant)

  1. Fixes Update magento/composer composer dependency to version 1.7.0 #33510

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jul 21, 2021

Hi @korovitskyi. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me platform-health instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jul 21, 2021
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jul 21, 2021
@korovitskyi
Copy link
Collaborator Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@korovitskyi korovitskyi mentioned this pull request Jul 21, 2021
Closed
5 tasks
@ihor-sviziev ihor-sviziev self-assigned this Jul 21, 2021
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Project: Platform Health labels Jul 21, 2021
@sivaschenko
Copy link
Member

@eduard13 please pay attention that any changes to composer json/lock require related PR to EE

Den4ik
Den4ik requested changes Jul 25, 2021
View reviewed changes
Copy link
Contributor

@Den4ik Den4ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@korovitskyi Could you please resolve merge conflict

@korovitskyi
Copy link
Collaborator Author

Hi, @Den4ik .
Conflicts were resolved.
Thank you.

@Den4ik
Copy link
Contributor

Den4ik commented Jul 25, 2021

@sivaschenko Could you explain why when we have related EE PRs build are empty?

@andrewbess
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

1 similar comment
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@andrewbess
Copy link
Contributor

Functional testing errors are not related with these changes.
I checked the API of the converter.
Currently, free service is unavailable.
503-in-console
api-server-status

andrewbess
andrewbess approved these changes Jul 25, 2021
View reviewed changes
Copy link
Contributor

@andrewbess andrewbess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @korovitskyi
Thank you for your contribution.
Changes are approved.

@andrewbess andrewbess merged commit f5cd707 into magento:platform-health Jul 25, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jul 25, 2021

Hi @korovitskyi, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@andrewbess andrewbess deleted the 33510-updated-magento-composer-version branch July 26, 2021 15:37
@hostep hostep mentioned this pull request Aug 4, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Den4ik Den4ik Den4ik approved these changes

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@andrewbess andrewbess andrewbess approved these changes

@eduard13 eduard13 eduard13 approved these changes

Assignees

@Den4ik Den4ik

@ihor-sviziev ihor-sviziev

@andrewbess andrewbess

@eduard13 eduard13

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing Project: Platform Health
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@korovitskyi @ihor-sviziev @sivaschenko @Den4ik @andrewbess @eduard13 @magento-engcom-team