WIP: [Ui] Clear date range filter by Clear button #33591

Den4ik · 2021-07-26T10:45:43Z

Description (*)

Recreation of #33027

Related Pull Requests

Fixed Issues (if relevant)

Fixes Admin Grid date range filter not working as expected #32456

Manual testing scenarios (*)

See Admin Grid date range filter not working as expected #32456

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

m2-assistant · 2021-07-26T10:45:46Z

Hi @Den4ik. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

Den4ik · 2021-07-26T10:46:30Z

@magento run all tests

magento-automated-testing · 2021-07-26T10:46:34Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev

Please fix failing tests

Den4ik · 2021-07-26T11:42:48Z

@ihor-sviziev working on fix

Den4ik · 2021-07-26T12:06:16Z

@magento give me 2.4-develop instance

magento-deployment-service · 2021-07-26T12:06:19Z

Hi @Den4ik. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2021-07-26T12:10:23Z

Hi @Den4ik, here is your Magento Instance: https://03e3622c910a34ec081d015b8c0b2b9e-2-4-develop.instances.magento-community.engineering
Admin access: https://03e3622c910a34ec081d015b8c0b2b9e-2-4-develop.instances.magento-community.engineering/admin_4222
Login: fb087bb2
Password: 408a433b4b52

Den4ik · 2021-07-27T09:07:30Z

@magento give me 2.4-develop instance

magento-deployment-service · 2021-07-27T09:07:32Z

Hi @Den4ik. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2021-07-27T09:11:09Z

Hi @Den4ik, here is your Magento Instance: https://03e3622c910a34ec081d015b8c0b2b9e-2-4-develop.instances.magento-community.engineering
Admin access: https://03e3622c910a34ec081d015b8c0b2b9e-2-4-develop.instances.magento-community.engineering/admin_23fd
Login: c3c432ee
Password: 4d1ba069acef

Den4ik · 2021-07-27T12:11:24Z

@magento run all tests

magento-automated-testing · 2021-07-27T12:11:32Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik · 2021-07-27T12:24:14Z

@magento run all tests

magento-automated-testing · 2021-07-27T12:24:21Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik · 2021-07-28T09:37:44Z

@magento give me 2.4-develop instance

magento-deployment-service · 2021-07-28T09:37:46Z

Hi @Den4ik. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2021-07-28T09:41:28Z

Hi @Den4ik, here is your Magento Instance: https://03e3622c910a34ec081d015b8c0b2b9e-2-4-develop.instances.magento-community.engineering
Admin access: https://03e3622c910a34ec081d015b8c0b2b9e-2-4-develop.instances.magento-community.engineering/admin_6fbd
Login: 37217dd1
Password: c07f50339625

magento-automated-testing · 2021-11-18T11:31:18Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik · 2021-11-19T10:44:35Z

@magento give me 2.4-develop instance

magento-deployment-service · 2021-11-19T10:44:39Z

Hi @Den4ik. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2021-11-19T10:49:02Z

Hi @Den4ik, here is your Magento Instance: https://03e3622c910a34ec081d015b8c0b2b9e-2-4-develop.instances.magento-community.engineering
Admin access: https://03e3622c910a34ec081d015b8c0b2b9e-2-4-develop.instances.magento-community.engineering/admin_21c6
Login: 6e3221cd
Password: 28fd135f6a4e

Signed-off-by: Denis Kopylov <dkopylov@magenius.team>

…-date-range-filter

Den4ik · 2021-11-19T12:23:19Z

@magento run all tests

magento-automated-testing · 2021-11-19T12:23:23Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik · 2021-11-22T11:06:34Z

@magento give me 2.4-develop instance

magento-deployment-service · 2021-11-22T11:06:37Z

Hi @Den4ik. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2021-11-22T11:10:35Z

Hi @Den4ik, here is your Magento Instance: https://03e3622c910a34ec081d015b8c0b2b9e-2-4-develop.instances.magento-community.engineering
Admin access: https://03e3622c910a34ec081d015b8c0b2b9e-2-4-develop.instances.magento-community.engineering/admin_ebf5
Login: 9125f126
Password: e5d258ac3a13

Signed-off-by: Denis Kopylov <dkopylov@magenius.team>

…-date-range-filter

Den4ik · 2021-11-22T13:04:23Z

@magento run all tests

magento-automated-testing · 2021-11-22T13:04:27Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Signed-off-by: Denis Kopylov <dkopylov@magenius.team>

Den4ik · 2021-11-23T13:04:22Z

@magento run all tests

magento-automated-testing · 2021-11-23T13:04:26Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-11-23T21:08:57Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2022-06-30T10:46:09Z

Hi @Den4ik,

Thank you for your contribution!

In order to proceed with this PR, first tried to reproduce the issue on latest magento 2.4-develop.

Followed mentioned reproduction steps in PR and found that the issue is not reproducible in the latest magento code base.

In Backend selected Sales > Orders section.
Clicked on "Filters”. Applied the date range filter on "purchase date”.
Clicked on "Clear all" to remove this filter

After removing the filter, when clicked on Filters again, found that the date range is cleared.

The issue is not reproducible as the applying and removing of the filter is working fine, closing this PR.

Please reopen and update if you wish to continue.

Thank you for your contribution.

Den4ik · 2022-06-30T20:22:02Z

@magento give me 2.4-develop instance

magento-deployment-service · 2022-06-30T20:22:07Z

Hi @Den4ik. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2022-06-30T20:26:33Z

Hi @Den4ik, here is your Magento Instance: https://45e666b08d1176b6a93358cdd2b4286d.instances.magento-community.engineering
Admin access: https://45e666b08d1176b6a93358cdd2b4286d.instances.magento-community.engineering/admin_43c2
Login: 36ec62ee
Password: c382f0e421bf

Den4ik · 2022-06-30T20:37:48Z

@engcom-Charlie Thanks for the update. Yep, issue was fixed

m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jul 26, 2021

magento-engcom-team added Area: Frontend Component: Sales Component: Ui Release Line: 2.4 labels Jul 26, 2021

m2-community-project bot added the Progress: pending review label Jul 26, 2021

Den4ik mentioned this pull request Jul 26, 2021

magento/magento2#32456: Admin Grid date range filter not working as expected. #33027

Closed

5 tasks

ihor-sviziev self-assigned this Jul 26, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Jul 26, 2021

ihor-sviziev requested changes Jul 26, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Jul 26, 2021

Den4ik added 2 commits November 19, 2021 15:22

Fixed date input formats

4232021

Signed-off-by: Denis Kopylov <dkopylov@magenius.team>

Merge remote-tracking branch 'origin/2.4-develop' into 32456-clearing…

18e2137

…-date-range-filter

Den4ik added 2 commits November 22, 2021 16:03

Test updates after review

bcfef86

Signed-off-by: Denis Kopylov <dkopylov@magenius.team>

Merge remote-tracking branch 'origin/2.4-develop' into 32456-clearing…

09c4161

…-date-range-filter

Den4ik added 2 commits November 23, 2021 15:48

Rollback BIC changes

7ca946c

Signed-off-by: Denis Kopylov <dkopylov@magenius.team>

Fix unit tests

efbd4af

Den4ik mentioned this pull request Nov 25, 2021

Fix admin localized date formatting #27311

Closed

4 tasks

engcom-Charlie self-assigned this Jun 29, 2022

engcom-Charlie closed this Jun 30, 2022

m2-community-project bot removed the Progress: needs update label Jun 30, 2022

Den4ik deleted the 32456-clearing-date-range-filter branch June 30, 2022 20:37

WIP: [Ui] Clear date range filter by Clear button #33591

WIP: [Ui] Clear date range filter by Clear button #33591

Uh oh!

Conversation

Den4ik commented Jul 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Jul 26, 2021

Uh oh!

Den4ik commented Jul 26, 2021

Uh oh!

magento-automated-testing bot commented Jul 26, 2021

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

Den4ik commented Jul 26, 2021

Uh oh!

Den4ik commented Jul 26, 2021

Uh oh!

magento-deployment-service bot commented Jul 26, 2021

Uh oh!

magento-deployment-service bot commented Jul 26, 2021

Uh oh!

Den4ik commented Jul 27, 2021

Uh oh!

magento-deployment-service bot commented Jul 27, 2021

Uh oh!

magento-deployment-service bot commented Jul 27, 2021

Uh oh!

Den4ik commented Jul 27, 2021

Uh oh!

magento-automated-testing bot commented Jul 27, 2021

Uh oh!

Den4ik commented Jul 27, 2021

Uh oh!

magento-automated-testing bot commented Jul 27, 2021

Uh oh!

Den4ik commented Jul 28, 2021

Uh oh!

magento-deployment-service bot commented Jul 28, 2021

Uh oh!

magento-deployment-service bot commented Jul 28, 2021

Uh oh!

magento-automated-testing bot commented Nov 18, 2021

Uh oh!

Den4ik commented Nov 19, 2021

Uh oh!

magento-deployment-service bot commented Nov 19, 2021

Uh oh!

magento-deployment-service bot commented Nov 19, 2021

Uh oh!

Den4ik commented Nov 19, 2021

Uh oh!

magento-automated-testing bot commented Nov 19, 2021

Uh oh!

Den4ik commented Nov 22, 2021

Uh oh!

magento-deployment-service bot commented Nov 22, 2021

Uh oh!

magento-deployment-service bot commented Nov 22, 2021

Uh oh!

Den4ik commented Nov 22, 2021

Uh oh!

magento-automated-testing bot commented Nov 22, 2021

Uh oh!

Den4ik commented Nov 23, 2021

Uh oh!

magento-automated-testing bot commented Nov 23, 2021

Uh oh!

magento-automated-testing bot commented Nov 23, 2021

Uh oh!

engcom-Charlie commented Jun 30, 2022

Uh oh!

Den4ik commented Jul 26, 2021 •

edited

Loading