33589 fix array values in catalogsearch parameters

[SilinMykola]

Description (*)

I changed a method that prepare values for advanced search. Model: \Magento\CatalogSearch\Model\Advanced

Fixed Issues (if relevant)

1. Fixes strlen() expects parameter 1 to be string, array given | magento/module-catalog-search #33589

Manual testing scenarios (*)

1. Open page with parameters: /catalogsearch/advanced/result/?price[from][]=1&price[to]=1
   For example: htps://base_url/catalogsearch/advanced/result/?price[from][]=1&price[to]=1

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @SilinMykola. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[SilinMykola]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[andrewbess]

@magento give me test instance

[magento-deployment-service]

Hi @andrewbess. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @andrewbess, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

[eduard13]

Hi @SilinMykola, could you please cover these changes by an integration test?

Thank you.

[andrewbess]

@magento give me test instance

[magento-deployment-service]

Hi @andrewbess. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @andrewbess, here is your Magento Instance: https://a3fe9860c4997848dc40cb217d7c0332.instances.magento-community.engineering
Admin access: https://a3fe9860c4997848dc40cb217d7c0332.instances.magento-community.engineering/admin_05dc
Login: 0252dc90
Password: 1d9c8a96fc28

[andrewbess]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[SilinMykola]

Hi @SilinMykola, could you please cover these changes by an integration test?

Thank you.

Hi! @eduard13 ! Ok, I'll create integration test for this model.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[SilinMykola]

@magento run Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

After discussion with @SilinMykola in slack and test possible one another solution I approve this PR as easiest an fast solution for now.
@SilinMykola Thanks for the work

[magento-engcom-team]

Hi @Den4ik, thank you for the review.
ENGCOM-9197 has been created to process this Pull Request
✳️ @Den4ik, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-9197 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Preconditions:

1. Install fresh Magento instance with sample data.

Manual testing scenario:

1. Front end: Click on "advanced search" link from the footer.

2. Set the price 1 to 1 and do search

3. Edit the resulted URL from /***/advanced/result/?name=&sku=&description=&short_description=&price%5Bfrom%5D=1&price%5Bto%5D=1 to /***/advanced/result/?price[from][]=1&price[to]=1

4. Validate the edited URL response in the web page.

Before: ✖️ Used to get an error message

After: ✔️ Gives the search result information

With no result data

With result data

There is no additional regression is required since it is a specific case where we are doing an URL tampering. It has no impact on any other features as well.

[m2-assistant]

Hi @SilinMykola, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.