Fixed bugs and add improvements for Newsletter Queue #33849

Usik2203 · 2021-08-18T12:40:26Z

Description

This PR fixes bugs and add improvements for Newsletter Queue functionality

Preconditions

For correct testing you should have more then 20 subscribers in newsletter_subscriber table
Create new Newsletter Templates in Marketing->Newsletter Templates
Create new Newsletter Queue

Screen.Recording.2021-08-18.at.15.56.20.mov

Issue case 1

Actual result

Run bin/magento cron:run --group=default , newsletter_send_all cron job should run Newsletter Queue
You will see that 20 emails were sent but we still have Not Sent status

I don't see any actions except Preview

Result after fix

Was fixed by appliing next changes https://github.com/magento/magento2/pull/33849/files#diff-1d2d0f2340ff4fc3e0907e98b2ccd1a21a35c777c503907bc3c12f0223eaeb8eR254

Correct status was set, i can see Pause, Cancel , Preview actions for queue

Issue case 2

After Issue case 1 was fixed next issue was reproduced

Actual result

All data were removed from Newsletter Queue after clicking Save and Resume button

Screen.Recording.2021-08-18.at.16.53.36.mov

Result after fix

Was fixed by appliing next changes https://github.com/magento/magento2/pull/33849/files#diff-f4e00fe342edaab019fbb62abfa0c2b8f5d7a2f179bd5880e4c217d57bbb7883R232

Data was saved correctly all data present

Screen.Recording.2021-08-18.at.17.12.18.mov

Issue case 3

Actual result

Save and Resume button always display even while creating new Newsletter Queue

Result after fix

Was fixed by appliing next changes https://github.com/magento/magento2/pull/33849/files#diff-d337328a9078b6f37102b714ffa5460b365c7ede7b97ca644bf2f0b8fe15b0dcR138

Save and Resume button displays only if Newsletter Queue has status Pause

Screen.Recording.2021-08-18.at.17.15.38.mov

Resolved issues:

resolves [Issue] Fixed bugs and add improvements for Newsletter Queue #36612: Fixed bugs and add improvements for Newsletter Queue

m2-assistant · 2021-08-18T12:40:28Z

Hi @Usik2203. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

Usik2203 · 2021-08-18T12:43:20Z

@magento run all tests

magento-automated-testing · 2021-08-18T12:43:28Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik · 2021-08-19T12:24:18Z

app/code/Magento/Newsletter/Model/Queue.php

+    private function startQueue()
+    {
+        $this->setQueueStatus(self::STATUS_SENDING);
+        $this->save();


Why do we still use deprecated method in core?

engcom-Charlie · 2022-08-03T13:41:33Z

@magento give me test instance

engcom-Charlie · 2022-08-04T11:08:38Z

@magento give me test instance

magento-deployment-service · 2022-08-04T11:08:42Z

Hi @engcom-Charlie. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2022-08-04T11:12:34Z

Hi @engcom-Charlie, here is your Magento Instance: https://3cba4c94c32bbcd522c1f3907ab57bdd.instances.magento-community.engineering
Admin access: https://3cba4c94c32bbcd522c1f3907ab57bdd.instances.magento-community.engineering/admin_461c
Login: 319d58d3
Password: a1db48bf7a25

engcom-Charlie · 2022-08-05T10:01:32Z

@magento run all tests

magento-automated-testing · 2022-08-05T10:01:37Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik · 2022-08-05T12:08:49Z

@engcom-Charlie Will you help with updating PR?

engcom-Charlie · 2022-08-05T13:48:25Z

Hi @Den4ik,

Yeah, will work on the review comments and on build failures.

Thank you!

Den4ik · 2022-08-05T19:48:18Z

@engcom-Charlie That's great 👍

engcom-Lima · 2022-12-15T07:20:32Z

@magento create issue

engcom-Echo · 2023-01-13T05:11:17Z

@magento run all tests

magento-automated-testing · 2023-01-13T05:11:23Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2023-01-13T06:31:43Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2023-01-13T07:37:44Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2023-01-13T08:04:05Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2023-01-13T08:24:51Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Echo · 2023-01-13T13:11:21Z

@magento run Functional Tests CE

magento-automated-testing · 2023-01-13T13:11:28Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Echo · 2023-01-16T05:21:50Z

Functional Tests B2B, Functional Tests EE,Functional Tests CE Failures are related to Currency Converter API.
Hence Moving to Merge In Progress

Added Newsletter queue improvements

d812f42

magento-engcom-team added Component: Newsletter Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Aug 18, 2021

m2-community-project bot added the Progress: pending review label Aug 18, 2021

Usik2203 changed the title ~~[Draft] Add Newsletter Queue improvements~~ Fixed bugs and add improvements for Newsletter Queue Aug 18, 2021

DmitryTsymbal mentioned this pull request Aug 18, 2021

Added additional info to Newsletter Queue Page magento/merchdocs#1435

Merged

Den4ik requested changes Aug 19, 2021

View reviewed changes

m2-community-project bot assigned Den4ik Aug 19, 2021

m2-community-project bot added Progress: needs update and removed Progress: pending review labels Aug 19, 2021

sidolov added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 28, 2021

Merge branch '2.4-develop' into newsletter-queue

03fb76a

engcom-Charlie self-assigned this Aug 3, 2022

Merge remote-tracking branch 'magento/2.4-develop' into newsletter-queue

c98e958

Merge remote-tracking branch 'magento/2.4-develop' into newsletter-queue

23ac7a0

FIxed static test failures

60907f4

m2-community-project bot added Progress: pending review Progress: pending approval and removed Progress: pending approval labels Dec 14, 2022

ishakhsuvarov removed the Progress: pending review label Dec 14, 2022

m2-assistant bot mentioned this pull request Dec 15, 2022

[Issue] Fixed bugs and add improvements for Newsletter Queue #36612

Closed

m2-community-project bot added Progress: ready for testing Progress: pending approval and removed Progress: pending approval Progress: ready for testing labels Dec 15, 2022

Fixed MFTF SVC failure

69a8867

m2-community-project bot added Progress: extended testing and removed Progress: pending approval labels Jan 13, 2023

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Jan 16, 2023

engcom-Echo self-assigned this Feb 20, 2023

m2-community-project bot added Progress: ready for testing Progress: accept and removed Progress: accept Progress: ready for testing labels Feb 20, 2023

magento-devops-reposync-svc merged commit 178c88c into magento:2.4-develop Mar 2, 2023

Fixed bugs and add improvements for Newsletter Queue #33849

Fixed bugs and add improvements for Newsletter Queue #33849

Uh oh!

Conversation

Usik2203 commented Aug 18, 2021 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Preconditions

Issue case 1

Actual result

Result after fix

Issue case 2

Actual result

Result after fix

Issue case 3

Actual result

Result after fix

Resolved issues:

Uh oh!

m2-assistant bot commented Aug 18, 2021

Uh oh!

Usik2203 commented Aug 18, 2021

Uh oh!

magento-automated-testing bot commented Aug 18, 2021

Uh oh!

Den4ik Aug 19, 2021

Choose a reason for hiding this comment

Uh oh!

engcom-Charlie commented Aug 3, 2022

Uh oh!

engcom-Charlie commented Aug 4, 2022

Uh oh!

magento-deployment-service bot commented Aug 4, 2022

Uh oh!

magento-deployment-service bot commented Aug 4, 2022

Uh oh!

engcom-Charlie commented Aug 5, 2022

Uh oh!

magento-automated-testing bot commented Aug 5, 2022

Uh oh!

Den4ik commented Aug 5, 2022

Uh oh!

engcom-Charlie commented Aug 5, 2022

Uh oh!

Den4ik commented Aug 5, 2022

Uh oh!

engcom-Lima commented Dec 15, 2022

Uh oh!

engcom-Echo commented Jan 13, 2023

Uh oh!

magento-automated-testing bot commented Jan 13, 2023

Uh oh!

magento-automated-testing bot commented Jan 13, 2023

Uh oh!

magento-automated-testing bot commented Jan 13, 2023

Uh oh!

magento-automated-testing bot commented Jan 13, 2023

Uh oh!

magento-automated-testing bot commented Jan 13, 2023

Uh oh!

engcom-Echo commented Jan 13, 2023

Uh oh!

magento-automated-testing bot commented Jan 13, 2023

Uh oh!

engcom-Echo commented Jan 16, 2023

Uh oh!

Uh oh!

Usik2203 commented Aug 18, 2021 •

edited by m2-assistant bot

Loading