Update jQuery.validate library #33871

eduard13 · 2021-08-20T11:50:45Z

Description (*)

This PR aims to update the jQuery.validate library to the latest 1.19.3 version and keep supporting the current version of jQuery.metadata library.

Related Pull Requests

https://github.com/magento/partners-magento2b2b/pull/583

Fixed Issues (if relevant)

Fixes Update Third Party library: jquery-validate #33853

Manual testing scenarios (*)

N/A

Questions or comments

ℹ️ For compatibility reasons with the existing code, for now we have to keep the jQuery.metadata library and the rest of adjustments that were made into this library.

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

m2-assistant · 2021-08-20T11:50:48Z

Hi @eduard13. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me platform-health instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

eduard13 · 2021-08-20T12:01:11Z

@magento run all tests

magento-automated-testing · 2021-08-20T12:01:16Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

lib/web/jquery/jquery.validate.js

magento-automated-testing · 2021-08-23T10:02:29Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

eduard13 · 2021-08-23T10:51:08Z

@magento run all tests

magento-automated-testing · 2021-08-23T10:51:13Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

eduard13 · 2021-08-24T11:28:11Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Static Tests

magento-automated-testing · 2021-08-24T11:28:15Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-08-24T14:00:59Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev

Please fix static test failure

eduard13 · 2021-08-25T06:38:11Z

@magento run Static Tests

magento-automated-testing · 2021-08-25T06:38:19Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

eduard13 · 2021-08-25T08:28:55Z

@magento run Static Tests

magento-automated-testing · 2021-08-25T08:29:02Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev · 2021-08-25T09:17:51Z

Static tests are passing
@magento run all test

magento-automated-testing · 2021-08-25T09:17:56Z

Failed to run the builds. Please try to re-run them later.

ihor-sviziev · 2021-08-25T09:19:00Z

@magento run all tests

magento-automated-testing · 2021-08-25T09:19:08Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

eduard13 · 2021-08-25T09:32:23Z

@magento run all tests

magento-automated-testing · 2021-08-25T09:32:27Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-08-25T11:29:20Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-08-25T11:29:23Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

andrewbess

Hello @eduard13
Thank you for your contribution.
Changes approved.
Waiting for builds

magento-automated-testing · 2021-08-25T14:55:52Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

m2-assistant · 2021-08-25T16:54:54Z

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

eduard13 added the Project: Platform Health label Aug 20, 2021

eduard13 requested a review from andrewbess August 20, 2021 11:50

eduard13 assigned andrewbess Aug 20, 2021

m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Aug 20, 2021

magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Aug 20, 2021

m2-community-project bot added the Progress: review label Aug 20, 2021

ihor-sviziev reviewed Aug 20, 2021

View reviewed changes

lib/web/jquery/jquery.validate.js Show resolved Hide resolved

m2-community-project bot assigned ihor-sviziev Aug 20, 2021

eduard13 force-pushed the update-jq-validate branch from 0172064 to f2a9345 Compare August 23, 2021 10:49

eduard13 force-pushed the update-jq-validate branch from f2a9345 to 96efa36 Compare August 24, 2021 11:26

eduard13 mentioned this pull request Aug 24, 2021

Update Third Party library: jquery.metadata #33730

Closed

ihor-sviziev requested changes Aug 25, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Aug 25, 2021

ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Progress: review labels Aug 25, 2021

m2-community-project bot added Progress: review Progress: needs update and removed Progress: needs update Progress: review labels Aug 25, 2021

Updating the jQuery.validate library

1cee6e9

eduard13 force-pushed the update-jq-validate branch from 96d3da3 to 1cee6e9 Compare August 25, 2021 09:32

andrewbess requested a review from ihor-sviziev August 25, 2021 12:38

andrewbess approved these changes Aug 25, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: needs update Progress: review labels Aug 25, 2021

ihor-sviziev approved these changes Aug 25, 2021

View reviewed changes

andrewbess added the Award: category of expertise label Aug 25, 2021

andrewbess merged commit 16cf35a into magento:platform-health Aug 25, 2021

Update jQuery.validate library #33871

Update jQuery.validate library #33871

Uh oh!

Conversation

eduard13 commented Aug 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Aug 20, 2021

Uh oh!

eduard13 commented Aug 20, 2021

Uh oh!

magento-automated-testing bot commented Aug 20, 2021

Uh oh!

Uh oh!

magento-automated-testing bot commented Aug 23, 2021

Uh oh!

eduard13 commented Aug 23, 2021

Uh oh!

magento-automated-testing bot commented Aug 23, 2021

Uh oh!

eduard13 commented Aug 24, 2021

Uh oh!

magento-automated-testing bot commented Aug 24, 2021

Uh oh!

magento-automated-testing bot commented Aug 24, 2021

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

eduard13 commented Aug 25, 2021

Uh oh!

magento-automated-testing bot commented Aug 25, 2021

Uh oh!

eduard13 commented Aug 25, 2021

Uh oh!

magento-automated-testing bot commented Aug 25, 2021

Uh oh!

ihor-sviziev commented Aug 25, 2021

Uh oh!

magento-automated-testing bot commented Aug 25, 2021

Uh oh!

ihor-sviziev commented Aug 25, 2021

Uh oh!

magento-automated-testing bot commented Aug 25, 2021

Uh oh!

eduard13 commented Aug 25, 2021

Uh oh!

magento-automated-testing bot commented Aug 25, 2021

Uh oh!

magento-automated-testing bot commented Aug 25, 2021

Uh oh!

magento-automated-testing bot commented Aug 25, 2021

Uh oh!

andrewbess left a comment

Choose a reason for hiding this comment

Uh oh!

magento-automated-testing bot commented Aug 25, 2021

Uh oh!

m2-assistant bot commented Aug 25, 2021

Uh oh!

Uh oh!

eduard13 commented Aug 20, 2021 •

edited

Loading