-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Update laminas server to php 8.1 compatible version #34279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update laminas server to php 8.1 compatible version #34279
Conversation
Hi @ihor-sviziev. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests B2B, Functional Tests CE |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ihor-sviziev
Thank you for your contribution here.
I think we also need to update composer.json
How do you think about it?
@andrewbess, I think we don't need to increase the minimum required version since PHP 8.1 will be available anyway. |
@xmav, what do you think? |
Hi! changes to composer.lock could be easily lost once someone will try to regenerate it. We primarily looking into versions in composer.json. Lets update constrain to ~2.11.0 in composer.json for this dependency |
@xmav, but it doesn't have any sense. You can run composer update any time and you'll have the newest version. The dependence actually hasn't changed. |
Sure you can do composer update and get fresh versions. When Magento installed from composer packages composer.lock file completely ignored and composer takes into account versions declared in composer.json. With existing constraint composer also will install v2.11.0 but lets try to keep constraints updated |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@andrewbess thx for updating |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Hi @ihor-sviziev, thank you for your contribution! |
Description (*)
Related Pull Requests
https://github.com/magento/partners-magento2ee/pull/627
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)