Skip to content

Conversation

ihor-sviziev
Copy link
Contributor

@ihor-sviziev ihor-sviziev commented Oct 8, 2021

Description (*)

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/627

Fixed Issues (if relevant)

  1. Fixes Provide PHP 8.1 support for laminas/laminas-server #34240

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 8, 2021

Hi @ihor-sviziev. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: pending review labels Oct 8, 2021
@ihor-sviziev ihor-sviziev changed the base branch from 2.4-develop to platform-health October 8, 2021 08:12
@ihor-sviziev
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev
Copy link
Contributor Author

@magento run Functional Tests B2B, Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Copy link
Contributor

@andrewbess andrewbess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ihor-sviziev
Thank you for your contribution here.
I think we also need to update composer.json
How do you think about it?

@ihor-sviziev
Copy link
Contributor Author

@andrewbess, I think we don't need to increase the minimum required version since PHP 8.1 will be available anyway.

@ihor-sviziev
Copy link
Contributor Author

@xmav, what do you think?

@xmav
Copy link
Contributor

xmav commented Oct 8, 2021

Hi! changes to composer.lock could be easily lost once someone will try to regenerate it. We primarily looking into versions in composer.json. Lets update constrain to ~2.11.0 in composer.json for this dependency

@ihor-sviziev
Copy link
Contributor Author

ihor-sviziev commented Oct 8, 2021

@xmav, but it doesn't have any sense. You can run composer update any time and you'll have the newest version. The dependence actually hasn't changed.
For PHP 8.1 you'll install the only version >= 2.11.0 as the only this version is starting supporting it

@xmav
Copy link
Contributor

xmav commented Oct 8, 2021

Sure you can do composer update and get fresh versions. When Magento installed from composer packages composer.lock file completely ignored and composer takes into account versions declared in composer.json. With existing constraint composer also will install v2.11.0 but lets try to keep constraints updated

@andrewbess
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev
Copy link
Contributor Author

@andrewbess thx for updating

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@andrewbess andrewbess merged commit 5ed944c into magento:platform-health Oct 10, 2021
@m2-assistant
Copy link

m2-assistant bot commented Oct 10, 2021

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide PHP 8.1 support for laminas/laminas-server
5 participants