Fix Varnish VCL Template to use path without /pub to health_check.php #34323

marvinhinz · 2021-10-12T13:01:27Z

Description (*)

As per Magento 2.4.2 the /pub directory is now the recommended document root, the default varnish vcl should be changed to reflect that too.

Related Pull Requests

Fixed Issues (if relevant)

Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Fix Varnish VCL Template to use path without /pub to health_check.php #36903: Fix Varnish VCL Template to use path without /pub to health_check.php

m2-assistant · 2021-10-12T13:01:30Z

Hi @marvinhinz. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

marvinhinz · 2021-10-12T13:04:56Z

@magento run all tests

magento-automated-testing · 2021-10-12T13:05:02Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-engcom-team · 2021-10-12T13:57:34Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-9247 has been created to process this Pull Request

ihor-sviziev

@marvinhinz please revert latest commit with changes in auto loader

This reverts commit 6713070.

marvinhinz · 2021-10-12T20:09:09Z

@ihor-sviziev oops, sorry i reverted it!

ihor-sviziev · 2021-10-13T06:14:44Z

@magento run all tests

magento-automated-testing · 2021-10-13T06:14:52Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev · 2021-10-15T09:10:40Z

@magento run Functional Tests B2B, Functional Tests CE, Unit Tests

magento-automated-testing · 2021-10-15T09:10:47Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev

✔ Approved.

Failing tests look not related to changes from this PR.

magento-engcom-team · 2021-10-15T16:48:32Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-9247 has been created to process this Pull Request

engcom-Charlie · 2022-12-22T11:25:14Z

@magento run all tests

magento-automated-testing · 2022-12-22T11:25:21Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2022-12-22T12:11:17Z

It seems that bot has moved this PR from Ready for Testing to Changes Requested, hence moving it back.

Thank you!

engcom-Charlie · 2022-12-23T07:02:17Z

@magento run all tests

magento-automated-testing · 2022-12-23T07:02:22Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2023-01-04T05:40:25Z

@magento run all tests

magento-automated-testing · 2023-01-04T05:40:30Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2023-01-04T07:10:53Z

Hi @marvinhinz , @ihor-sviziev , @torhoehn,

Thank you for your contribution!

✔️ QA Passed
Varnish .vcl is using path without /pub to health_check.php

Preconditions:

Configure varnish and confirmed that varnish is working successfully.

Steps to reproduce:

Checked that magento instance’s doc root is /pub
Configure magento instance's .host and .port in varnish's vcl file
Applied the PR changes into the varnish4.vcl, varnish5.vcl and varnish6.vcl files as per the updates.

Before:
In apache logs, found that health_check.php call is going with /pub and its showing 404 status

After:
We are getting, health_check.php call is going without /pub and its showing 200 status

Thank you!

engcom-Charlie · 2023-01-04T09:19:07Z

@magento run Integration Tests

magento-automated-testing · 2023-01-04T09:19:16Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2023-01-04T11:31:23Z

@magento run Integration Tests

magento-automated-testing · 2023-01-04T11:31:27Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2023-01-04T14:39:42Z

The failing tests are not related to the PR changes or not failing because of PR. Hence moving it to Merge In Progress.

Thank you!

engcom-Lima · 2023-02-22T09:34:13Z

@magento create issue

marvinhinz added 3 commits October 12, 2021 14:51

Update varnish4.vcl

7fa0082

Update varnish5.vcl

5626117

Update varnish6.vcl

6f0601a

magento-engcom-team added the Component: PageCache label Oct 12, 2021

magento-engcom-team added the Release Line: 2.4 label Oct 12, 2021

ihor-sviziev approved these changes Oct 12, 2021

View reviewed changes

m2-community-project bot assigned ihor-sviziev Oct 12, 2021

m2-community-project bot added the Progress: ready for testing label Oct 12, 2021

ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Oct 12, 2021

Update Autoloader.php

6713070

ihor-sviziev requested changes Oct 12, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: ready for testing labels Oct 12, 2021

Revert "Update Autoloader.php"

0e2e10c

This reverts commit 6713070.

ihor-sviziev added the Progress: review label Oct 13, 2021

m2-community-project bot removed the Progress: needs update label Oct 13, 2021

ihor-sviziev approved these changes Oct 15, 2021

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Oct 15, 2021

engcom-Charlie self-assigned this Dec 22, 2022

m2-community-project bot added Progress: needs update and removed Progress: ready for testing labels Dec 22, 2022

Merge remote-tracking branch 'magento/2.4-develop' into 2.4-develop

e02907e

m2-community-project bot added Progress: ready for testing and removed Progress: needs update labels Dec 22, 2022

Merge remote-tracking branch 'magento/2.4-develop' into 2.4-develop

aa47e4c

Merge remote-tracking branch 'magento/2.4-develop' into 2.4-develop

f9c877c

m2-community-project bot added Progress: accept and removed Progress: ready for testing labels Jan 4, 2023

m2-assistant bot mentioned this pull request Feb 22, 2023

[Issue] Fix Varnish VCL Template to use path without /pub to health_check.php #36903

Closed

5 tasks

m2-community-project bot added Progress: needs update Progress: accept and removed Progress: accept Progress: needs update labels Feb 22, 2023

magento-devops-reposync-svc merged commit b39beca into magento:2.4-develop Mar 2, 2023

Fix Varnish VCL Template to use path without /pub to health_check.php #34323

Fix Varnish VCL Template to use path without /pub to health_check.php #34323

Uh oh!

Conversation

marvinhinz commented Oct 12, 2021 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Oct 12, 2021

Uh oh!

marvinhinz commented Oct 12, 2021

Uh oh!

magento-automated-testing bot commented Oct 12, 2021

Uh oh!

magento-engcom-team commented Oct 12, 2021

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

marvinhinz commented Oct 12, 2021

Uh oh!

ihor-sviziev commented Oct 13, 2021

Uh oh!

magento-automated-testing bot commented Oct 13, 2021

Uh oh!

ihor-sviziev commented Oct 15, 2021

Uh oh!

magento-automated-testing bot commented Oct 15, 2021

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Oct 15, 2021

Uh oh!

engcom-Charlie commented Dec 22, 2022

Uh oh!

magento-automated-testing bot commented Dec 22, 2022

Uh oh!

engcom-Charlie commented Dec 22, 2022

Uh oh!

engcom-Charlie commented Dec 23, 2022

Uh oh!

magento-automated-testing bot commented Dec 23, 2022

Uh oh!

engcom-Charlie commented Jan 4, 2023

Uh oh!

magento-automated-testing bot commented Jan 4, 2023

Uh oh!

engcom-Charlie commented Jan 4, 2023

Uh oh!

engcom-Charlie commented Jan 4, 2023

Uh oh!

magento-automated-testing bot commented Jan 4, 2023

Uh oh!

engcom-Charlie commented Jan 4, 2023

Uh oh!

magento-automated-testing bot commented Jan 4, 2023

Uh oh!

engcom-Charlie commented Jan 4, 2023

Uh oh!

engcom-Lima commented Feb 22, 2023

Uh oh!

Uh oh!

marvinhinz commented Oct 12, 2021 •

edited by m2-assistant bot

Loading