Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#34991 GraphQL Bundle Options generates wrong DB request and result: … #34992

Merged
merged 6 commits into from
Oct 18, 2022
Merged

#34991 GraphQL Bundle Options generates wrong DB request and result: … #34992

merged 6 commits into from
Oct 18, 2022

Conversation

novakivskiy
Copy link
Contributor

@novakivskiy novakivskiy commented Jan 19, 2022 •
edited by sidolov
Loading

Fixes #34991

@novakivskiy
magento#34991 GraphQL Bundle Options generates wrong DB request and r…
05c5ff0 
…esult: add extract "entity_id" from $this->skuMap for where condition
@m2-assistant
Copy link

m2-assistant bot commented Jan 19, 2022

Hi @novakivskiy. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Jan 19, 2022
@dniprotrophy dniprotrophy mentioned this pull request Jan 20, 2022
Closed
@m2-community-project m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Jan 20, 2022
@m2-community-project m2-community-project bot removed this from Pending Review in Pull Requests Dashboard Jan 20, 2022
@nuzil
Copy link
Contributor

nuzil commented Jan 21, 2022

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@nuzil
Copy link
Contributor

nuzil commented Jan 21, 2022

@novakivskiy
Would be awesome if you can add GraphQL Api tests. is it something you can do?

@nuzil nuzil self-requested a review January 21, 2022 15:58
@m2-community-project m2-community-project bot moved this from Pending Review to Ready for Testing in High Priority Pull Requests Dashboard Jan 24, 2022
@magento-engcom-team
Copy link
Contributor

Hi @nuzil, thank you for the review.
ENGCOM-9393 has been created to process this Pull Request
✳️ @nuzil, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta engcom-Delta self-assigned this Jan 25, 2022
@engcom-Delta engcom-Delta moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Jan 25, 2022
@engcom-Alfa engcom-Alfa self-assigned this Jan 25, 2022
@m2-community-project m2-community-project bot moved this from Testing in Progress to Ready for Testing in High Priority Pull Requests Dashboard Jan 25, 2022
@engcom-Alfa
Copy link
Contributor

@magento run Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie engcom-Charlie moved this from Ready for Testing to Extended Testing (optional) in High Priority Pull Requests Dashboard Feb 3, 2022
engcom-Alfa
engcom-Alfa requested changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@engcom-Alfa engcom-Alfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @novakivskiy Thanks much for your contribution over here!
But, since additionally we require an auto-test covered for this case, can you please help us covering that too?
Thanks in advance!

@m2-community-project m2-community-project bot moved this from Extended Testing (optional) to Changes Requested in High Priority Pull Requests Dashboard Feb 7, 2022
@engcom-Charlie
Copy link
Contributor

Hi @novakivskiy,

Thank you for your contribution!

I am working on WebAPI test for this PR.

Thank you!

@engcom-Charlie
Copy link
Contributor

Hi @engcom-Alfa,

I have merged 2.4-develop and added GraphQL Web API test for this scenario.

Thank you!

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@nuzil nuzil added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Feb 16, 2022
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B

@engcom-Charlie
Copy link
Contributor

The Functional B2B test case which is getting failed in build is not part of this PR or not faling because of changes made in this PR.

  • app/code/Magento/InventoryInStorePickupFrontend/Test/Mftf/Test/StorefrontGuestBillingAddressPreselectedTest.xml

Since we have covered auto test here hence moving this PR to Merge in Progress.

Thank you!

@engcom-Charlie engcom-Charlie moved this from Changes Requested to Merge in Progress in High Priority Pull Requests Dashboard Feb 17, 2022
@ishakhsuvarov
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit e1ec129 into magento:2.4-develop Oct 18, 2022
@ishakhsuvarov ishakhsuvarov moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Alfa engcom-Alfa engcom-Alfa requested changes

@nuzil nuzil nuzil approved these changes

Assignees

@nuzil nuzil

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

@engcom-Delta engcom-Delta

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: BundleGraphQl Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GraphQL Bundle Options generates wrong DB request and result
8 participants
@novakivskiy @nuzil @magento-engcom-team @engcom-Alfa @engcom-Delta @engcom-Charlie @ishakhsuvarov @magento-devops-reposync-svc