#34991 GraphQL Bundle Options generates wrong DB request and result: …

[novakivskiy]

Fixes #34991

[m2-assistant]

Hi @novakivskiy. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[nuzil]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[nuzil]

@novakivskiy
Would be awesome if you can add GraphQL Api tests. is it something you can do?

[magento-engcom-team]

Hi @nuzil, thank you for the review.
ENGCOM-9393 has been created to process this Pull Request
✳️ @nuzil, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Alfa]

@magento run Functional Tests CE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Delta]

Try to reproduce the issue without PR code changes and able to replicate , below are the steps to reproduce.
Pre-Condtion:

1. Have fresh instance without sample data.
2. Have 10 Products (So that if you create new product , entity id will be in double digits )

Steps:

1. Go to Catalog --> Products
2. Note latest product entity ID Ex: 10
3. Create new bundle product by name 12DE01-E & use same name for sku id ( Here the product name started with 12 and this value is calculated by incrementing 2 by value of step#2)
   4 Make sure that bundle product has product options, Category selected, Product Images (which is created in step3)
4. Create second bundle product any name & sku id
5. Do Cache flush
6. Do reindexing
7. Run Below graphql query by inputing product name 12DE01 which was created at step 3
8. Validate the response

Expected issue:
Receiving response "Internal server error"

Request:
`{products(
filter: { sku: { eq: "14B01-B" } }
) {
items {
id
type_id
name
sku
... on BundleProduct {
items{
option_id
}
}
}

}
}Response:{
"errors": [
{
"message": "Internal server error",
"extensions": {
"category": "internal"
},
"locations": [
{
"line": 10,
"column": 9
}
],
"path": [
"products",
"items",
0,
"items"
]
}
],
"data": {
"products": {
"items": [
{
"id": 13,
"type_id": "bundle",
"name": "14B01-B",
"sku": "14B01-B",
"items": null
}
]
}
}
}`

[engcom-Delta]

After PR code Changes it works as expected and below is the working screenshot.

It is a Graphql ticket and it has no automation test case covered , I hope it is recommended to cover automation test for this scenario and Hence moving this ticket to 'Extended Testing' status.

[engcom-Alfa]

Hi @novakivskiy Thanks much for your contribution over here!
But, since additionally we require an auto-test covered for this case, can you please help us covering that too?
Thanks in advance!

[engcom-Charlie]

Hi @novakivskiy,

Thank you for your contribution!

I am working on WebAPI test for this PR.

Thank you!

[engcom-Charlie]

Hi @engcom-Alfa,

I have merged 2.4-develop and added GraphQL Web API test for this scenario.

Thank you!

[engcom-Charlie]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Charlie]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Charlie]

@magento run Functional Tests B2B

[engcom-Charlie]

The Functional B2B test case which is getting failed in build is not part of this PR or not faling because of changes made in this PR.

• app/code/Magento/InventoryInStorePickupFrontend/Test/Mftf/Test/StorefrontGuestBillingAddressPreselectedTest.xml

Since we have covered auto test here hence moving this PR to Merge in Progress.

Thank you!

[ishakhsuvarov]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.