Add nl_BE and fr_BE languages for Belgium #3504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For our Belgian customers it would be very nice if their languages were also supported. Although Belgians speak Dutch and French there is a profound difference between Dutch and Flemish (nl_BE) and between French and Walloon (fr_BE). They require different language packs. Although nl_BE and fr_BE can be easily added with a plugin - which is my current solution - it's a small change to add it to the Magento code. I think the Belgians would be thankful.
|
We would be. |
|
Internal issue MAGETWO-50074 |
|
@ajpevers Thank you for contribution. Your Pull Request merged to develop branch |
|
Great, thanks! |
vkorotun
added
Issue: Ready for Work
magento-engcom-team
pushed a commit
that referenced
this pull request
Dec 8, 2018
[pangolin] Converting MTF to MFTF tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For our Belgian customers it would be very nice if their languages were also supported. Although Belgians speak Dutch and French there is a profound difference between Dutch and Flemish (nl_BE) and between French and Walloon (fr_BE). They require different language packs.
Although nl_BE and fr_BE can be easily added with a plugin - which is my current solution - it's a small change to add it to the Magento code. I think the Belgians would be thankful.