-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix GraphQL login as customer token not working for multi stores #35080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @fiifiappiah. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review. For more details, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento create issue |
Hi @shikhamis11, Thank you for your contribution! Can you please do the code review so that we can move this PR further towards merging. Thank you! |
Hi @fiifiappiah, Thank you for your contribution! It seems that the issue has been resolved in commit on 2.4-develop I have also tried to reproduce this issue by following ways:
Observed that, generateCustomerTokenAsAdmin mutation is working fine as expected by providing the token. On the basis of above findings and since the issue is now not reproducible on 2.4-develop branch closing this PR. Please reopen and update if you wish to continue. Thank you for your contribution! |
Description (*)
When a magento install with more than one store tries to utilize the login as Customer GraphQl to get a token for any store other than the default store- an error is thrown for customers not being found even when they exist.
Manual testing scenarios (*)
mutation{
generateCustomerTokenAsAdmin(input: {
customer_email: "test@test.com"
}){
customer_token
}
}
Contribution checklist (*)
Resolved issues: