Skip to content

Added missing interface for Quote\Address\Item #35296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ilnytskyi
Copy link
Contributor

Description (*)

When working on customization that include both quote_item and quote_address_item (e.g. multishipping) it's impossible to work under one interface. \Magento\Quote\Model\Quote\Item\AbstractItem must be used instead. So quote_address_item can be also marked as \Magento\Quote\Api\Data\CartItemInterface

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 13, 2022

Hi @ilnytskyi. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ilnytskyi
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Copy link
Contributor

@manavluhar manavluhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @ilnytskyi I doubt about the approval of this Pull Request, Also to take this further, you must need to update your PR by implementing the needful methods, which comes under \Magento\Quote\Api\Data\CartItemInterface. You can refer to the implementation at \Magento\Quote\Model\Qoute\Item.

@engcom-Hotel engcom-Hotel added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Apr 26, 2022
@engcom-Dash engcom-Dash self-assigned this Dec 5, 2024
@engcom-Dash
Copy link
Contributor

Hey, @ilnytskyi I doubt about the approval of this Pull Request, Also to take this further, you must need to update your PR by implementing the needful methods, which comes under \Magento\Quote\Api\Data\CartItemInterface. You can refer to the implementation at \Magento\Quote\Model\Qoute\Item.

@ilnytskyi: Thanks for your contributions! Could you please address this review comment? Also, if possible, please elaborate on the issue in more detail; that would be appreciated. Thanks.

@engcom-Dash
Copy link
Contributor

Hey, @ilnytskyi I doubt about the approval of this Pull Request, Also to take this further, you must need to update your PR by implementing the needful methods, which comes under \Magento\Quote\Api\Data\CartItemInterface. You can refer to the implementation at \Magento\Quote\Model\Qoute\Item.

@ilnytskyi: Thanks for your contributions! Could you please address this review comment? Also, if possible, please elaborate on the issue in more detail; that would be appreciated. Thanks.

Hello @ilnytskyi,

This is a reminder: Could you please take a look at this #35296 (comment)

Thanks.

@engcom-Dash
Copy link
Contributor

Hello @ilnytskyi,

This is a reminder: Could you please take a look at this #35296 (comment)

Thanks.

@engcom-Dash
Copy link
Contributor

Closing this PR as it has not been updated for a while. Please feel free to reopen it if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants