-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Added missing interface for Quote\Address\Item #35296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @ilnytskyi. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review. For more details, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @ilnytskyi I doubt about the approval of this Pull Request, Also to take this further, you must need to update your PR by implementing the needful methods, which comes under \Magento\Quote\Api\Data\CartItemInterface. You can refer to the implementation at \Magento\Quote\Model\Qoute\Item.
@ilnytskyi: Thanks for your contributions! Could you please address this review comment? Also, if possible, please elaborate on the issue in more detail; that would be appreciated. Thanks. |
Hello @ilnytskyi, This is a reminder: Could you please take a look at this #35296 (comment) Thanks. |
Hello @ilnytskyi, This is a reminder: Could you please take a look at this #35296 (comment) Thanks. |
Closing this PR as it has not been updated for a while. Please feel free to reopen it if needed. |
Description (*)
When working on customization that include both quote_item and quote_address_item (e.g. multishipping) it's impossible to work under one interface.
\Magento\Quote\Model\Quote\Item\AbstractItem
must be used instead. So quote_address_item can be also marked as\Magento\Quote\Api\Data\CartItemInterface
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)