Skip to content

Show last login date/time on admin user grid #35356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

fredden
Copy link
Member

@fredden fredden commented Apr 22, 2022

Description

When managing administrative user accounts within the Magento backend, it would be useful to see when particular users have most recently logged in. This pull request adds that information to the grid. (The information already exists in the database.)

Manual testing scenarios

  1. Navigate to the admin System -> Permissions -> All Users
  2. Notice the list of admin users lacks information about the last log-in date/time.
  3. Apply the changes in this pull request.
  4. Notice the list of admin users now shows the last log-in date/time of each user.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Show last login date/time on admin user grid #35587: Show last login date/time on admin user grid

@m2-assistant
Copy link

m2-assistant bot commented Apr 22, 2022

Hi @fredden. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-github-services m2-github-services added Partner: Fisheye partners-contribution Pull Request is created by Magento Partner labels Apr 22, 2022
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@nuzil
Copy link
Contributor

nuzil commented Apr 27, 2022

@fredden will it be possible to add test coverage for this feature?

@nuzil nuzil self-requested a review April 27, 2022 14:12
@sidolov sidolov added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Apr 28, 2022
@Den4ik Den4ik self-requested a review April 30, 2022 06:40
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jun 7, 2022
@ihor-sviziev ihor-sviziev self-assigned this Jun 7, 2022
@engcom-Alfa
Copy link
Contributor

@magento create issue

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Preconditions:

  1. Have Magento Installed with latest 2.4-develop code, and admin login working properly!

Manual testing scenario:

  1. Navigate to the admin System >> Permissions >> All Users
  2. Notice the list of admin users grid columns and check last Last Logged in column existence.

Before: ✖️ There was no Last Logged in column in the grid
image

After: ✔️ New column Last Logged in introduced
image

Additionally,

  1. With an existing admin user login after some time-gap, checked the date and time getting updated!
  2. By creating a new admin and logging in first time, we will not see the time updated in the column. But once the admin logs out and re-logs in, the last logged in time gets updated in the column.

As part of regression, we will have one test case created.

As of now, we are not able to see documentation about the Users grid in the relevant doc section. We have to confirm within the team, whether we require to update the documentation.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 984274a into magento:2.4-develop Jun 11, 2022
@fredden fredden deleted the admin-security/last-login-display branch June 11, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: Fisheye partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Type: Feature/Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Show last login date/time on admin user grid
7 participants