-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Passing null to parameter #1 ($string) of type string #35441
Fix Passing null to parameter #1 ($string) of type string #35441
Conversation
Hi @nazarklovanych. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review. For more details, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Hello @nazarklovanych |
03473ee
to
a6aa519
Compare
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Great stuff! Thanks :-) |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests CE |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests CE |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Hi @engcom-Alfa, I have merged latest 2.4-develop into this PR branch and resolved all the conflicts. You can proceed with testing. Thank you! |
@magento run all test |
Failed to run the builds. Please try to re-run them later. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
✔️ QA Passed Executed with the steps as shown in above-comment. Before: ✖️ We were getting an error as mentioned in the same above-comment. After: ✔️ Consumer able start command execution without any errors! No additional regression testing required to be added since it is relevant to the command failure fix with particular PHP version. |
@magento run Functional Tests EE |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests EE |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Even after multiple tried "Functional Tests EE" job is getting failed! Hence moving the PR to Extended Testing. |
@magento run Functional Tests EE |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
As the build is successful now, moving this PR to Merge in Progress. Thank you! |
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Install fresh (vanilla) Magento instance
1.1 composer create-project --repository-url=https://repo.magento.com/ magento/project-community-edition
1.2 run install with AMQP: e.g. bin/magento setup:install --base-url="http://magento-ce.test/" --base-url-secure="https://magento-ce.test/" --use-secure-admin=1 --use-rewrites=1 --use-secure=1 --db-host="127.0.0.1" --db-name=magento_ce --db-user=root --db-password=root --backend-frontname=admin --admin-firstname=admin --admin-lastname=admin --admin-email=admin@magento-ce.test --admin-user=admin --admin-password=admin123 --language=en_US --currency=EUR --timezone=Europe/Berlin --amqp-host=localhost --amqp-port=5672 --amqp-user=admin --amqp-password=admin --amqp-virtualhost=magento_ce --elasticsearch-host=localhost --elasticsearch-port=9207 --session-save=redis --session-save-redis-host=localhost --session-save-redis-port=6379 --session-save-redis-db=0 --cache-backend=redis --cache-backend-redis-server=localhost --cache-backend-redis-port=6379 --cache-backend-redis-db=1 --page-cache=redis --page-cache-redis-server=localhost --page-cache-redis-port=6379 --page-cache-redis-db=2 --cleanup-database
Start MQ consumer like: bin/magento queue:consumer:start async.operations.all
Questions or comments
Contribution checklist (*)