Fix Passing null to parameter #1 ($string) of type string

[nazarklovanych]

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes [Magento 2.4.4] MQ consumers run into issue "Deprecated Functionality: trim() .. magento/framework-amqp/Config.php on line 143" on PHP 8.1 #35380

Manual testing scenarios (*)

Install fresh (vanilla) Magento instance
1.1 composer create-project --repository-url=https://repo.magento.com/ magento/project-community-edition
1.2 run install with AMQP: e.g. bin/magento setup:install --base-url="http://magento-ce.test/" --base-url-secure="https://magento-ce.test/" --use-secure-admin=1 --use-rewrites=1 --use-secure=1 --db-host="127.0.0.1" --db-name=magento_ce --db-user=root --db-password=root --backend-frontname=admin --admin-firstname=admin --admin-lastname=admin --admin-email=admin@magento-ce.test --admin-user=admin --admin-password=admin123 --language=en_US --currency=EUR --timezone=Europe/Berlin --amqp-host=localhost --amqp-port=5672 --amqp-user=admin --amqp-password=admin --amqp-virtualhost=magento_ce --elasticsearch-host=localhost --elasticsearch-port=9207 --session-save=redis --session-save-redis-host=localhost --session-save-redis-port=6379 --session-save-redis-db=0 --cache-backend=redis --cache-backend-redis-server=localhost --cache-backend-redis-port=6379 --cache-backend-redis-db=1 --page-cache=redis --page-cache-redis-server=localhost --page-cache-redis-port=6379 --page-cache-redis-db=2 --cleanup-database
Start MQ consumer like: bin/magento queue:consumer:start async.operations.all

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @nazarklovanych. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[nazarklovanych]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[karyna-t]

Hello @nazarklovanych
Could you please fix failed static tests?
Thank you in advance.

[nazarklovanych]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[nuzil]

Great stuff! Thanks :-)

[ishakhsuvarov]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[glo71317]

@magento run Functional Tests CE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[glo71317]

@magento run Functional Tests CE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[glo71317]

@magento run Functional Tests CE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Alfa]

Hi @nazarklovanych, @Den4ik and @ishakhsuvarov Thanks for your contribution and collaboration.
We have reproduced the issue using below steps:

Pre-Conditions:

1. Should have PHP 8.1 running.
2. Should have RabbitMQ installed and enabled.
3. Should have Redis installed and enabled.

Steps:

1. Install fresh (vanilla) Magento instance using a command: composer create-project --repository-url=https://repo.magento.com/ magento/project-community-edition <install-directory-name>
2. Run install with AMQP: e.g. bin/magento setup:install --base-url="http://magento-ce.test/" --base-url-secure="https://magento-ce.test/" --use-secure-admin=1 --use-rewrites=1 --use-secure=1 --db-host="127.0.0.1" --db-name=magento_ce --db-user=root --db-password=root --backend-frontname=admin --admin-firstname=admin --admin-lastname=admin --admin-email=admin@magento-ce.test --admin-user=admin --admin-password=admin123 --language=en_US --currency=EUR --timezone=Europe/Berlin --amqp-host=localhost --amqp-port=5672 --amqp-user=admin --amqp-password=admin --amqp-virtualhost=magento_ce --elasticsearch-host=localhost --elasticsearch-port=9207 --session-save=redis --session-save-redis-host=localhost --session-save-redis-port=6379 --session-save-redis-db=0 --cache-backend=redis --cache-backend-redis-server=localhost --cache-backend-redis-port=6379 --cache-backend-redis-db=1 --page-cache=redis --page-cache-redis-server=localhost --page-cache-redis-port=6379 --page-cache-redis-db=2 --cleanup-database
3. Above 2 commands will successfully execute, and then follow by the next command: bin/magento queue:consumer:start async.operations.all
4. Validate the outcome of the command

Observation:
We are getting the error as mentioned expected issue shown in below screenshot.

In order to take the ticket thru further process to merge, we have to re-test with the file changes in this PR. So, as we can see there are Merge conflicts in the PR branch, kindly resolve the merge conflicts.
Thanks in advance!

[engcom-Alfa]

Because of the above-comment, requested for changes

[engcom-Charlie]

Hi @engcom-Alfa,

I have merged latest 2.4-develop into this PR branch and resolved all the conflicts.

You can proceed with testing.

Thank you!

[engcom-Alfa]

@magento run all test

[magento-automated-testing]

Failed to run the builds. Please try to re-run them later.

[engcom-Alfa]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Alfa]

✔️ QA Passed

Executed with the steps as shown in above-comment.

Before: ✖️ We were getting an error as mentioned in the same above-comment.

After: ✔️ Consumer able start command execution without any errors!

No additional regression testing required to be added since it is relevant to the command failure fix with particular PHP version.

[engcom-Alfa]

@magento run Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Alfa]

@magento run Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Alfa]

Even after multiple tried "Functional Tests EE" job is getting failed! Hence moving the PR to Extended Testing.

[engcom-Charlie]

@magento run Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Charlie]

As the build is successful now, moving this PR to Merge in Progress.

Thank you!