Integration Tests: `setup:install` command hangs when question provided #35948

lbajsarowicz · 2022-08-15T11:03:56Z

Description (*)

This Pull Request adds --no-interaction flag in order to avoid the situation when setup:install (or any other command) gets stuck due to the question asked in a non-interactive environment.

Related Pull Requests

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

Add class that asks question after Magento installation (e.g. about Config import)
Execute Magento Integration Tests

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Integration Tests: setup:install command hangs when question provided #36539: Integration Tests: setup:install command hangs when question provided

m2-assistant · 2022-08-15T11:03:59Z

Hi @lbajsarowicz. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

lbajsarowicz · 2022-08-15T11:04:23Z

@magento run all tests

magento-automated-testing · 2022-08-15T11:04:32Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev · 2022-08-15T15:52:50Z

@lbajsarowicz, shouldn't we add similar for setup:install?

lbajsarowicz · 2022-08-15T16:35:04Z

@ihor-sviziev I added it here:
https://github.com/magento/magento2/pull/35948/files#diff-f52136b2dfa5c36438fc1969770d5a968b040984ee336dc9362854e53193b071R552

ihor-sviziev

Please fix unit tests failure

ihor-sviziev · 2022-08-15T17:45:08Z

I also had similar issue on GitHub Actions, it was just now showing any result for a long time and then was just cancelled by me. It was really hard to debug such case doe to missing any output and logs.
The real issue was caused by incorrect credentials to MySQL server for integration tests

ihor-sviziev · 2022-10-17T11:21:37Z

@lbajsarowicz any updates?

lbajsarowicz · 2022-10-17T22:53:44Z

@magento run Unit Tests

magento-automated-testing · 2022-10-17T22:53:52Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

lbajsarowicz · 2022-10-17T22:55:45Z

@magento run all tests

magento-automated-testing · 2022-10-17T22:55:52Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

lbajsarowicz · 2022-10-17T22:56:52Z

@ihor-sviziev I updated Unit Tests.

ihor-sviziev · 2022-10-18T04:43:21Z

@magento run all tests

magento-automated-testing · 2022-10-18T04:43:25Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

ihor-sviziev · 2022-10-18T08:14:03Z

@lbajsarowicz still failing :(

ishakhsuvarov · 2022-10-20T17:58:12Z

Moving to extended testing in hopes that someone would be able to stabilize the tests and get it delivered.

engcom-Delta · 2022-11-28T08:51:34Z

@magento create issue

engcom-Delta · 2022-11-28T12:16:20Z

Hi @lbajsarowicz,
Thanks for the collaboration & contribution!
We have tried to reproduce the issue in magento 2.4-develop it is not reproducible and following steps are followed to reproduce.

Add class that asks question after Magento installation
a. Enabled magento production mode.
b. Created website, store, and storeview from backend
c. Magento setup:upgrade && di:compile
d. bin/magento app:config:dump
e. change the store name.
f. bin/magento app:config:import (command line)after these steps we are getting as below

Run Magento Integration Tests we are getting as below

If there are any steps missing or we are following a different approach, please let us know.

Thanks.

lbajsarowicz · 2022-11-28T13:37:37Z

@engcom-Delta Even if you cannot reproduce the issue, the headless processes should be run in --non-interactive mode, because you can not interact with the CLI during Integration Tests execution. Saying that, please proceed with processing this Pull Request.

engcom-Echo · 2022-12-14T12:18:42Z

@lbajsarowicz
Thanks for the collaboration & contribution!

✔️ QA Passed
Integration Tests: setup:install command hangs when question provided

Manual Scenario Steps

Add class that asks question after Magento installation
Execute Magento Integration Tests

Before: ✖️
installation is not successful.

After: ✔️
Test gets executed after successful installation.

engcom-Charlie · 2023-01-31T17:41:02Z

It seems bot moved this PR from Merge in Progress to Ready for Testing hence moving it back.

Integration Tests: setup:install command hangs when question provided

72d7d9b

ihor-sviziev requested changes Aug 15, 2022

View reviewed changes

m2-community-project bot assigned ihor-sviziev Aug 15, 2022

m2-community-project bot added the Progress: needs update label Aug 15, 2022

ihor-sviziev added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Aug 15, 2022

ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Aug 17, 2022

Resolve Unit Tests

c658924

Merge branch '2.4-develop' into qa-integration-tests-setup-hangs

6123afb

ihor-sviziev added the Progress: review label Oct 18, 2022

m2-community-project bot removed the Progress: needs update label Oct 18, 2022

ihor-sviziev added the Progress: needs update label Oct 18, 2022

m2-community-project bot removed the Progress: review label Oct 18, 2022

m2-community-project bot removed the Progress: needs update label Oct 20, 2022

m2-community-project bot added the Progress: pending review label Nov 4, 2022

engcom-Echo removed their assignment Nov 7, 2022

m2-community-project bot added Progress: needs update Progress: pending review and removed Progress: pending review Progress: needs update labels Nov 7, 2022

ishakhsuvarov approved these changes Nov 10, 2022

View reviewed changes

m2-community-project bot assigned ishakhsuvarov Nov 10, 2022

m2-community-project bot added Progress: ready for testing and removed Progress: pending review labels Nov 10, 2022

engcom-Delta self-assigned this Nov 24, 2022

m2-assistant bot mentioned this pull request Nov 28, 2022

[Issue] Integration Tests: setup:install command hangs when question provided #36539

Closed

5 tasks

engcom-Delta added the Issue: needs update Additional information is require, waiting for response label Nov 28, 2022

engcom-Lima added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Dec 5, 2022

engcom-Echo self-assigned this Dec 14, 2022

m2-community-project bot added Progress: testing in progress Progress: accept and removed Progress: ready for testing labels Dec 14, 2022

engcom-Charlie self-assigned this Jan 31, 2023

m2-community-project bot added Progress: ready for testing and removed Progress: accept Progress: testing in progress labels Jan 31, 2023

m2-community-project bot added Progress: accept and removed Progress: ready for testing labels Jan 31, 2023

magento-devops-reposync-svc merged commit 8a46f66 into magento:2.4-develop Feb 14, 2023

Integration Tests: setup:install command hangs when question provided #35948

Integration Tests: setup:install command hangs when question provided #35948

Uh oh!

Conversation

lbajsarowicz commented Aug 15, 2022 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Aug 15, 2022

Uh oh!

lbajsarowicz commented Aug 15, 2022

Uh oh!

magento-automated-testing bot commented Aug 15, 2022

Uh oh!

ihor-sviziev commented Aug 15, 2022

Uh oh!

lbajsarowicz commented Aug 15, 2022

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

ihor-sviziev commented Aug 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ihor-sviziev commented Oct 17, 2022

Uh oh!

lbajsarowicz commented Oct 17, 2022

Uh oh!

magento-automated-testing bot commented Oct 17, 2022

Uh oh!

lbajsarowicz commented Oct 17, 2022

Uh oh!

magento-automated-testing bot commented Oct 17, 2022

Uh oh!

lbajsarowicz commented Oct 17, 2022

Uh oh!

ihor-sviziev commented Oct 18, 2022

Uh oh!

magento-automated-testing bot commented Oct 18, 2022

Uh oh!

ihor-sviziev commented Oct 18, 2022

Uh oh!

ishakhsuvarov commented Oct 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

engcom-Delta commented Nov 28, 2022

Uh oh!

engcom-Delta commented Nov 28, 2022

Uh oh!

lbajsarowicz commented Nov 28, 2022

Uh oh!

engcom-Echo commented Dec 14, 2022

Uh oh!

engcom-Charlie commented Jan 31, 2023

Uh oh!

Uh oh!

Integration Tests: `setup:install` command hangs when question provided #35948

Integration Tests: `setup:install` command hangs when question provided #35948

lbajsarowicz commented Aug 15, 2022 •

edited by m2-assistant bot

Loading

ihor-sviziev commented Aug 15, 2022 •

edited

Loading

ishakhsuvarov commented Oct 20, 2022 •

edited

Loading