Issue 35284: Hitting enter when configuring a product to add to order… #36173

rogerdz · 2022-09-21T17:30:29Z

Description (*)

Magento Admin - Hitting enter when configuring a product to add to order in admin does not save the custom options

Related Pull Requests

Fixed Issues (if relevant)

Fixes Magento Admin - Hitting enter when configuring a product to add to order in admin does not save the custom options #35284

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

… in admin does not save the custom options

m2-assistant · 2022-09-21T17:30:31Z

Hi @rogerdz. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

rogerdz · 2022-09-21T17:31:01Z

@magento run all tests

magento-automated-testing · 2022-09-21T17:31:07Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

edenduong

Thank you for your contribution !
P/S: This PR can be covered by MFTF test (It is similar AdminCreateOrderWithConfigurableProductTest test case with AdminAddToOrderConfigurableProductActionGroup action group). You can created it to cover this change. Could you please add it ? I think it is more better.

edenduong

Thank you for your contribution !
P/S: This PR can be covered by MFTF test (It is similar AdminCreateOrderWithConfigurableProductTest test case and AdminAddToOrderConfigurableProductActionGroup action group with small modify). You can created new test case to cover this change. Could you please add it ? I think it is more better.

magento-automated-testing · 2022-09-22T09:09:41Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2022-09-22T09:09:44Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2022-09-22T09:09:47Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

rogerdz · 2022-09-22T15:41:55Z

@edenduong I added MFTF test

rogerdz · 2022-09-22T15:42:09Z

@magento run all tests

magento-automated-testing · 2022-09-22T15:42:13Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

edenduong · 2022-09-23T00:40:37Z

...de/Magento/Sales/Test/Mftf/Test/AdminCreateOrderWithConfigurableProductPressKeyEnterTest.xml

+            <stories value="AC-2040"/>
+            <description value="Create order with configurable product."/>
+            <features value="Sales"/>
+            <testCaseId value="AC-2040"/>


It is duplicate testCaseId in Magento. I think you can leave it as empty like that test case

I removed it ^^

I added new commit

rogerdz · 2022-09-23T01:52:59Z

@magento run all tests

magento-automated-testing · 2022-09-23T01:53:08Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

edenduong · 2022-09-23T06:36:52Z

...de/Magento/Sales/Test/Mftf/Test/AdminCreateOrderWithConfigurableProductPressKeyEnterTest.xml

+            <title value="Create Order in Admin with configurable product"/>
+            <description value="Create order with configurable product."/>


Could you please add "with pressing enter key in option select modal" to title and description to separate it with the normal flow ? Thanks

thank @edenduong, I added new commit

rogerdz · 2022-09-23T07:27:32Z

@magento run all tests

magento-automated-testing · 2022-09-23T07:27:40Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Lima · 2022-12-20T14:43:32Z

@magento give me 2.4-develop instance

magento-deployment-service · 2022-12-20T14:43:34Z

Hi @engcom-Lima. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2022-12-20T14:47:31Z

Hi @engcom-Lima, here is your Magento Instance: https://976871a84f6ea94e39085a705e724217.instances.magento-community.engineering
Admin access: https://976871a84f6ea94e39085a705e724217.instances.magento-community.engineering/admin_9add
Login: bfd8dc3b
Password: 0f3f27d53a16

engcom-Lima · 2022-12-21T06:30:30Z

This PR is already merged. Hence, moving this PR to recently merged.

engcom-Lima · 2022-12-21T06:30:58Z

✔️ QA Passed

Issue 35284: Hitting enter when configuring a product to add to order…

f3920a9

… in admin does not save the custom options

m2-community-project bot added Priority: P3 May be fixed according to the position in the backlog. Progress: pending review labels Sep 21, 2022

edenduong approved these changes Sep 22, 2022

View reviewed changes

m2-community-project bot assigned edenduong Sep 22, 2022

m2-community-project bot added Progress: ready for testing and removed Progress: pending review labels Sep 22, 2022

edenduong added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Progress: pending review and removed Progress: ready for testing labels Sep 22, 2022

m2-community-project bot added Progress: pending review Progress: ready for testing and removed Progress: pending review labels Sep 22, 2022

edenduong requested changes Sep 22, 2022

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: ready for testing Progress: pending review labels Sep 22, 2022

Issue 35284: add mftf

bc67be5

edenduong requested changes Sep 23, 2022

View reviewed changes

edenduong added Award: MFTF test coverage and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Sep 23, 2022

edenduong added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix and removed Award: MFTF test coverage labels Sep 23, 2022

Issue 35284: update code

c263019

m2-community-project bot added Progress: review and removed Progress: needs update labels Sep 23, 2022

Issue 35284: update mftf

b71b790

edenduong requested changes Sep 23, 2022

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Sep 23, 2022

Issue 35284: update code

6782453

m2-community-project bot added Progress: review and removed Progress: needs update labels Sep 23, 2022

edenduong approved these changes Sep 23, 2022

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Sep 23, 2022

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Dec 20, 2022

magento-devops-reposync-svc merged commit b7b4479 into magento:2.4-develop Dec 20, 2022

		<title value="Create Order in Admin with configurable product"/>
		<description value="Create order with configurable product."/>

Issue 35284: Hitting enter when configuring a product to add to order… #36173

Issue 35284: Hitting enter when configuring a product to add to order… #36173

Uh oh!

Conversation

rogerdz commented Sep 21, 2022

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Sep 21, 2022

Uh oh!

rogerdz commented Sep 21, 2022

Uh oh!

magento-automated-testing bot commented Sep 21, 2022

Uh oh!

edenduong left a comment

Choose a reason for hiding this comment

Uh oh!

edenduong left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

magento-automated-testing bot commented Sep 22, 2022

Uh oh!

magento-automated-testing bot commented Sep 22, 2022

Uh oh!

magento-automated-testing bot commented Sep 22, 2022

Uh oh!

rogerdz commented Sep 22, 2022

Uh oh!

rogerdz commented Sep 22, 2022

Uh oh!

magento-automated-testing bot commented Sep 22, 2022

Uh oh!

edenduong Sep 23, 2022

Choose a reason for hiding this comment

Uh oh!

rogerdz Sep 23, 2022

Choose a reason for hiding this comment

Uh oh!

rogerdz Sep 23, 2022

Choose a reason for hiding this comment

Uh oh!

rogerdz commented Sep 23, 2022

Uh oh!

magento-automated-testing bot commented Sep 23, 2022

Uh oh!

edenduong Sep 23, 2022

Choose a reason for hiding this comment

Uh oh!

rogerdz Sep 23, 2022

Choose a reason for hiding this comment

Uh oh!

rogerdz commented Sep 23, 2022

Uh oh!

magento-automated-testing bot commented Sep 23, 2022

Uh oh!

engcom-Lima commented Dec 20, 2022

Uh oh!

magento-deployment-service bot commented Dec 20, 2022

Uh oh!

magento-deployment-service bot commented Dec 20, 2022

Uh oh!

engcom-Lima commented Dec 21, 2022

Uh oh!

engcom-Lima commented Dec 21, 2022

Uh oh!

Uh oh!

edenduong left a comment •

edited

Loading