#1291 - moved dependencies in correct module #3632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
some tests are failing, because of this line. You cannot have concatenation in a constant. But that's not my fault. |
|
@tzyganu Please sync with develop. Builds errors have been fixed. |
|
@mazhalai Done, but something else fails |
|
@strajeru possibly a travis issue. Restarted build. |
|
Internal ticket: MAGETWO-52471 |
okorshenko
added
Issue: Ready for Work
|
@tzyganu your pull request merged to develop branch. Thank you for your contribution. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Feb 1, 2019
Fixed: MAGETWO-66872 Customer Address Attribute not being marked as required when the "Values Required" setting is overriden on Website scope MAGETWO-95820 Order placed by new customer before they registered is displayed in the admin under the name Guest MAGETWO-95822 Layered Navigation shows options not available in Catalog MAGETWO-95823 Order Sales Report includes canceled orders MAGETWO-95310 [2.3] Wrong color image when filtering by color filter MAGETWO-57337 [Github] #5077 Store View (language) switch leads to 404 MAGETWO-96124 [2.3.x] Custom Customer Attributes get cleared in case of invalid Customer Account creation on Storefront MAGETWO-95817 Issue in Redeeming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1291 was marked as closed but not all the problems reported there were fixed.
I moved some dependencies in the correct module.
One side effect of this is that I eliminated one dependency from the EAV module to the Catalog module.
There are others, but I'm working on them 😄
Summary:
Magento\Authorization\Model\UserContextInterfacein the Authorization module