#482 - added meta title field to cms pages #3636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tzyganu Please sync with develop. Builds have been fixed. |
|
Internal ticket: MAGETWO-50238 |
hshar7
added
the
Issue: Ready for Work
| */ | ||
| public function upgrade(SchemaSetupInterface $setup, ModuleContextInterface $context) | ||
| { | ||
| $setup->startSetup(); |
There was a problem hiding this comment.
start/end-Setup might not be necessary here. Better to not use it, if it's not needed. It disables FK validation.
|
@mazhalai can you please restart the tests. some are failing with |
|
@strajeru Builds restarted. |
|
@strajeru Thank you for contribution. Your Pull Request merged to develop branch. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Jan 26, 2019
[EngCom] Public Pull Requests - GraphQL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.