Use constructor property promotion in module send friend graph ql #37197
Conversation
Replace allmost all properties with constructor property promotion in module send friend graph ql: https://stitcher.io/blog/constructor-promotion-in-php-8 Readable code * Make Magento less complex by removing properties which take up a lot of lines. * Imported all classes to make code more readable. I think the code would be a lot cleaner if all modules start using constructor promotions, since of 2.4.6 php 7.4 is dropped we can now make use of it. So let's start on it right now.
|
Hi @leonhelmus. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
m2-github-services
added
Partner: Youwe
partners-contribution
|
@magento run all tests |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
|
@m2-github-services help |
engcom-Lima
added
the
Triage: Dev.Experience
|
@magento create issue |
engcom-Bravo
added
the
Priority: P2
m2-community-project
bot
added
the
Priority: P3
|
QA is not required for this change since it only replaces variables with the constructor promotion property. Builds are failing, so moving it to extended testing. |
…romotion-send-friend-graph-ql
|
@magento run all tests |
|
@magento run Functional Tests CE, Functional Tests B2B |
|
The Functional B2B test failures are different in recent 2 successive builds and seems flaky. Hence moving this PR to merge in progress. |
|
@engcom-Dash are you picking up all my pull requests 😄? If so i will put some more effort and add some more prs 😁 |
@leonhelmus Sorry, I just saw this today! Feel free to keep those PRs coming—we’d be more than happy to work on them 😄 |
…romotion-send-friend-graph-ql
|
@magento run all tests |
|
@magento run all tests |
|
@magento run Functional Tests B2B, Functional Tests CE, Integration Tests |
engcom-Dash
moved this from Merge in Progress
to Extended Testing (optional)
in Pull Requests Dashboard
|
@magento run Functional Tests B2B, Functional Tests CE, Integration Tests |
|
Test failures for Functional B2B are inconsistent and seems to be flaky. They neither part of PR nor failing because of the PR changes.
Test failures for Functional CE are inconsistent and seems to be flaky. They neither part of PR nor failing because of the PR changes.
Hence Moving this PR in Merge In Progress. |
engcom-Dash
moved this from Extended Testing (optional)
to Merge in Progress
in Pull Requests Dashboard
magento-devops-reposync-svc
merged commit a8b93fe
into
magento:2.4-develop
ct-prd-projects-boards-automation
bot
moved this from Merge in Progress
to Recently Merged
in Pull Requests Dashboard
Description (*)
Replace allmost all properties with constructor property promotion in module send friend graph ql: https://stitcher.io/blog/constructor-promotion-in-php-8
Readable code
I think the code would be a lot cleaner if all modules start using constructor promotions, since of 2.4.6 php 7.4 is dropped we can now make use of it. So let's start on it right now.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)
Resolved issues: