Use visibility class for category product indexer, instead of hardcoded values #37199

Nuranto · 2023-03-13T11:15:52Z

Replace hardcoded values by using proper class in category product indexer. This fix provides more modularity.

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Fixes [Issue] Use visibility class for category product indexer, instead of hardcoded values #37200

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Use visibility class for category product indexer, instead of hardcoded values #37200: Use visibility class for category product indexer, instead of hardcoded values

…ed values

m2-assistant · 2023-03-13T11:15:56Z

Hi @Nuranto. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

Nuranto · 2023-03-13T11:16:27Z

@magento create issue

Nuranto · 2023-03-13T11:16:35Z

@magento run all tests

magento-automated-testing · 2023-03-13T11:16:41Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Nuranto · 2023-03-15T17:27:52Z

@magento run Static Tests, Unit Tests, Integration Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B

magento-automated-testing · 2023-03-15T17:28:02Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik

Hi @Nuranto Thanks for this code improvement. Please look at my comment.

app/code/Magento/Catalog/Model/Config.php

app/code/Magento/Catalog/Model/Indexer/Category/Product/AbstractAction.php

…ed values

Nuranto · 2023-03-22T17:05:42Z

@magento run all tests

magento-automated-testing · 2023-03-22T17:05:48Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Nuranto · 2023-03-23T07:20:25Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Static Tests, Unit Tests, WebAPI Tests

magento-automated-testing · 2023-03-23T07:20:35Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Nuranto · 2023-04-03T08:40:08Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Static Tests, Unit Tests

magento-automated-testing · 2023-04-03T08:40:18Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Nuranto · 2023-04-04T14:43:32Z

@magento run Functional Tests CE, Static Tests

magento-automated-testing · 2023-04-04T14:43:42Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Hotel

Hello @Nuranto,

Thanks for the contribution!

Changes are pretty straightforward and look good to me. Hence approving this PR for further process.

Failed tests seem flaky to me.

Den4ik

@engcom-Hotel Agree, all looks good

engcom-November · 2024-04-19T07:47:15Z

Hi @Nuranto,

Tried to update the pr to latest branch but got 403 error, Hence moving it to on hold.
Could you please update the branch so we can move further with the pr.

…bility-fix

Nuranto · 2024-04-19T08:09:07Z

done.

engcom-November · 2024-04-19T08:39:03Z

@magento run all tests

engcom-November · 2024-04-19T10:52:41Z

@magento run Functional Tests B2B, Functional Tests EE

engcom-November · 2024-04-19T12:33:54Z

This is a code-quality pr, no manual testing is required.

As the builds are failing moving this to Extended testing.

engcom-November · 2024-04-22T09:29:54Z

The repeated failures for functional Tests B2B and EE are flaky. These are knows issues and are not related to PR changes.

Functinal Tests B2B:
1st run:

2nd run:

Known failure : ACQE-6438 - StorefrontPropertiesOfAProductAttributeTest

Functinal Tests EE:
1st run:

2nd run:

Known failure :
ACQE-6224 - AdminContentHierarchyDisabledScopeWebsiteFilterTest
ACQE-6331 - StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest

engcom-November · 2024-04-22T09:37:18Z

WebAPI Failures are not related to PR changes, these are known issues.

WebAPI Tests:

Known failure: AC-11750 - RetrieveOrdersByOrderNumberTest

Hence moving this to merge in progress.

engcom-Charlie · 2024-04-29T08:44:49Z

@engcom-November as per this, I can see that there is one failure i.e StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest on which no data have been provided. Please provide more detail information on this. (mention open JIRA) till then moving it back to Extended Testing

engcom-November · 2024-04-29T09:13:28Z

@engcom-Charlie, I have updated the comment with the open jira of StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest, hence moving it back to Merge in Progress.

Use visibility class for category product indexer, instead of hardcod…

31656f2

…ed values

m2-assistant bot mentioned this pull request Mar 13, 2023

[Issue] Use visibility class for category product indexer, instead of hardcoded values #37200

Closed

5 tasks

m2-community-project bot added the Progress: pending review label Mar 13, 2023

m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Mar 16, 2023

Den4ik requested changes Mar 22, 2023

View reviewed changes

app/code/Magento/Catalog/Model/Config.php Outdated Show resolved Hide resolved

m2-community-project bot assigned Den4ik Mar 22, 2023

m2-community-project bot added Progress: needs update Progress: review and removed Progress: pending review Progress: needs update labels Mar 22, 2023

Den4ik reviewed Mar 22, 2023

View reviewed changes

app/code/Magento/Catalog/Model/Config.php Outdated Show resolved Hide resolved

Den4ik reviewed Mar 22, 2023

View reviewed changes

app/code/Magento/Catalog/Model/Indexer/Category/Product/AbstractAction.php Outdated Show resolved Hide resolved

Use visibility class for category product indexer, instead of hardcod…

95e6a20

…ed values

engcom-Hotel approved these changes Apr 8, 2024

View reviewed changes

m2-community-project bot assigned engcom-Hotel Apr 8, 2024

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Apr 8, 2024

engcom-Hotel added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Apr 8, 2024

Den4ik approved these changes Apr 8, 2024

View reviewed changes

engcom-November self-assigned this Apr 19, 2024

m2-community-project bot added Progress: on hold and removed Progress: ready for testing labels Apr 19, 2024

Merge branch 'magento:2.4-develop' into category-product-indexer-visi…

70e4fcb

…bility-fix

m2-community-project bot added Progress: testing in progress and removed Progress: on hold labels Apr 19, 2024

m2-community-project bot added Progress: extended testing and removed Progress: testing in progress labels Apr 19, 2024

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Apr 22, 2024

m2-community-project bot added Progress: extended testing and removed Progress: accept labels Apr 29, 2024

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Apr 29, 2024

magento-devops-reposync-svc merged commit 4be01f6 into magento:2.4-develop May 16, 2024

Use visibility class for category product indexer, instead of hardcoded values #37199

Use visibility class for category product indexer, instead of hardcoded values #37199

Uh oh!

Conversation

Nuranto commented Mar 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Questions or comments

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Mar 13, 2023

Uh oh!

Nuranto commented Mar 13, 2023

Uh oh!

Nuranto commented Mar 13, 2023

Uh oh!

magento-automated-testing bot commented Mar 13, 2023

Uh oh!

Nuranto commented Mar 15, 2023

Uh oh!

magento-automated-testing bot commented Mar 15, 2023

Uh oh!

Den4ik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nuranto commented Mar 22, 2023

Uh oh!

magento-automated-testing bot commented Mar 22, 2023

Uh oh!

Nuranto commented Mar 23, 2023

Uh oh!

magento-automated-testing bot commented Mar 23, 2023

Uh oh!

Nuranto commented Apr 3, 2023

Uh oh!

magento-automated-testing bot commented Apr 3, 2023

Uh oh!

Nuranto commented Apr 4, 2023

Uh oh!

magento-automated-testing bot commented Apr 4, 2023

Uh oh!

engcom-Hotel left a comment

Choose a reason for hiding this comment

Uh oh!

Den4ik left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-November commented Apr 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nuranto commented Apr 19, 2024

Uh oh!

engcom-November commented Apr 19, 2024

Uh oh!

engcom-November commented Apr 19, 2024

Uh oh!

engcom-November commented Apr 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

engcom-November commented Apr 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

engcom-November commented Apr 22, 2024

Uh oh!

engcom-Charlie commented Apr 29, 2024

Uh oh!

engcom-November commented Apr 29, 2024

Uh oh!

Uh oh!

Nuranto commented Mar 13, 2023 •

edited

Loading

engcom-November commented Apr 19, 2024 •

edited

Loading

engcom-November commented Apr 19, 2024 •

edited

Loading

engcom-November commented Apr 22, 2024 •

edited

Loading