Gtag ecommerce tracking improvements #37504

Bashev · 2023-05-16T07:27:26Z

Description (*)

Related Pull Requests

https://github.com/magento-gl/magento2-infrastructure/pull/26

Fixed Issues (if relevant)

Fixes GTag not send transaction prices and totals. #37348

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

…acking

m2-assistant · 2023-05-16T07:27:29Z

Hi @Bashev. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

Bashev · 2023-05-16T07:28:18Z

@magento run all tests

magento-automated-testing · 2023-05-16T07:28:27Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

# Conflicts: # app/code/Magento/GoogleGtag/Block/Ga.php # app/code/Magento/GoogleGtag/Test/Unit/Block/GaTest.php

Bashev · 2023-09-13T14:08:23Z

@magento run all tests

magento-automated-testing · 2023-09-13T14:08:31Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Hotel · 2023-09-18T08:40:28Z

@magento run all tests

magento-automated-testing · 2023-09-18T08:40:38Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Hotel

Hello @Bashev,

Thanks for the contribution!

Please review my comment below and fix the build failures below.

Thanks

app/code/Magento/GoogleGtag/Block/Ga.php

engcom-Echo · 2023-12-13T10:26:06Z

@magento run all tests

magento-automated-testing · 2023-12-13T10:26:16Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Echo · 2023-12-14T06:02:34Z

@magento run Functional Tests CE

magento-automated-testing · 2023-12-14T06:02:45Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Echo · 2023-12-14T06:10:48Z

✔️ QA Passed

Preconditions:

Install fresh Magento 2.4-develop

Manual testing scenario:

We have follow steps from comment
Create Coupon and Use same coupon.

Before: ✖️ Coupon and Discount data is not present in gtag data

After: ✔️ Coupon and Discount is present in gtag data

Builds are failing, Hence moving to Extended Testing

engcom-Echo · 2023-12-15T05:01:04Z

@magento run all tests

magento-automated-testing · 2023-12-15T05:01:13Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Echo · 2023-12-15T07:18:07Z

@magento run Integration Tests,Functional Tests B2B

magento-automated-testing · 2023-12-15T07:18:15Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Echo · 2023-12-15T09:20:05Z

Functional Tests B2B builds are green and Static Tests are known failure.
Hence moving it to Merge In Progress

engcom-Charlie · 2024-01-29T04:59:00Z

Hi @Bashev,

As per the static test failure:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/37504/2e4c1e56737a74d963734ed5da13d4d0/Statics/console-error-logs.html

The view layer changes have been detected in the GoogleGtag module. The GoogleGtagGraphQl module is expected to be updated to reflect these changes. The test failure can be ignored if the changes can not be covered with GraphQL API.

In order to proceed further we need to green build so can you please look into this and update the PR accordingly. Moving this to Changes Requested now.

Thank you!

engcom-Charlie · 2024-02-12T11:12:07Z

Hi @Bashev,

As mentioned in above comment, static test failure need to be fix in order to proceed further on this PR. Currently closing this PR, please feel free to reopen for any updates from your end.

Thank you!

Bashev · 2024-02-12T11:40:02Z

@engcom-Charlie I cannot find the module mentioned in the test GoogleTagGraphQl, probably i miss something, but in the repository this module is not visible?

Bashev and others added 15 commits April 8, 2023 13:05

move currency to order, change escapers and remove developer id.

7547ddf

changes to pass semantic version and Code style checks.

877d5da

changes to pass semantic version tests checks.

6802680

cast store id.

167d5b1

add coupon and fix unit tests.

fc3fe20

Merge branch '2.4-develop' into Issue-37348-gtag-ecommerce-tracking

dc95870

add proper unit tests

53479e9

add dependencies.

eaf5168

Delete phpunit.xml.dist

e595cce

Merge branch 'magento:2.4-develop' into Issue-37348-gtag-ecommerce-tr…

4afa7e1

…acking

revert phpunit.xml.dist

55b63dc

cast GrandTotal value to float.

7c6e9bc

Merge branch '2.4-develop' into Issue-37348-gtag-ecommerce-tracking

7f4f6d9

Merge branch '2.4-develop' into gtag-ecommerce-tracking-improvements

813e82f

Improvements on GoogleGTag resolve issue magento#37348

170987a

m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review labels May 16, 2023

Merge branch '2.4-develop' into gtag-ecommerce-tracking-improvements

cef14af

# Conflicts: # app/code/Magento/GoogleGtag/Block/Ga.php # app/code/Magento/GoogleGtag/Test/Unit/Block/GaTest.php

sinhaparul added the Project: Community Picked PRs upvoted by the community label Sep 13, 2023

Merge branch '2.4-develop' into gtag-ecommerce-tracking-improvements

258b38b

engcom-Hotel requested changes Sep 18, 2023

View reviewed changes

app/code/Magento/GoogleGtag/Block/Ga.php Outdated Show resolved Hide resolved

app/code/Magento/GoogleGtag/Block/Ga.php Outdated Show resolved Hide resolved

m2-community-project bot assigned engcom-Hotel Sep 18, 2023

m2-community-project bot removed the Progress: pending review label Sep 18, 2023

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Dec 13, 2023

Merge branch '2.4-develop' into gtag-ecommerce-tracking-improvements

dc01c68

m2-community-project bot added Progress: extended testing Progress: ready for testing and removed Progress: testing in progress Progress: extended testing labels Dec 14, 2023

Merge branch '2.4-develop' into gtag-ecommerce-tracking-improvements

0f3444e

m2-community-project bot added Progress: extended testing and removed Progress: ready for testing labels Dec 15, 2023

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Dec 15, 2023

m2-community-project bot added Progress: needs update and removed Progress: accept labels Jan 29, 2024

engcom-Charlie closed this Feb 12, 2024

m2-community-project bot removed the Progress: needs update label Feb 12, 2024

Bashev mentioned this pull request Jun 10, 2024

Fix issue #37348: Google GTag add ecommerce data fix. #37349

Merged

5 tasks

Gtag ecommerce tracking improvements #37504

Gtag ecommerce tracking improvements #37504

Uh oh!

Conversation

Bashev commented May 16, 2023 • edited by engcom-Echo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented May 16, 2023

Uh oh!

Bashev commented May 16, 2023

Uh oh!

magento-automated-testing bot commented May 16, 2023

Uh oh!

Bashev commented Sep 13, 2023

Uh oh!

magento-automated-testing bot commented Sep 13, 2023

Uh oh!

engcom-Hotel commented Sep 18, 2023

Uh oh!

magento-automated-testing bot commented Sep 18, 2023

Uh oh!

engcom-Hotel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

engcom-Echo commented Dec 13, 2023

Uh oh!

magento-automated-testing bot commented Dec 13, 2023

Uh oh!

engcom-Echo commented Dec 14, 2023

Uh oh!

magento-automated-testing bot commented Dec 14, 2023

Uh oh!

engcom-Echo commented Dec 14, 2023

✔️ QA Passed

Uh oh!

engcom-Echo commented Dec 15, 2023

Uh oh!

magento-automated-testing bot commented Dec 15, 2023

Uh oh!

engcom-Echo commented Dec 15, 2023

Uh oh!

magento-automated-testing bot commented Dec 15, 2023

Uh oh!

engcom-Echo commented Dec 15, 2023

Uh oh!

engcom-Charlie commented Jan 29, 2024

Uh oh!

engcom-Charlie commented Feb 12, 2024

Uh oh!

Bashev commented Feb 12, 2024

Uh oh!

Uh oh!

Bashev commented May 16, 2023 •

edited by engcom-Echo

Loading