Skip to content

Conversation

yogesh-valiya
Copy link
Member

@yogesh-valiya yogesh-valiya commented Aug 4, 2023

Description (*)

The words item and items are incorrectly used in the layered navigation filter item.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fix wording of filter item on layered navigation #38789: Fix wording of filter item on layered navigation

@m2-assistant
Copy link

m2-assistant bot commented Aug 4, 2023

Hi @yogesh-valiya. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@yogesh-valiya
Copy link
Member Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Hotel engcom-Hotel added the Priority: P3 May be fixed according to the position in the backlog. label Aug 8, 2023
@sinhaparul sinhaparul added the Project: Community Picked PRs upvoted by the community label May 21, 2024
@Den4ik
Copy link
Contributor

Den4ik commented May 25, 2024

@magento run all tests

@engcom-Hotel engcom-Hotel self-requested a review May 31, 2024 09:47
@engcom-Bravo engcom-Bravo self-assigned this Jun 4, 2024
@engcom-Bravo
Copy link
Contributor

@magento run all tests

@engcom-Bravo
Copy link
Contributor

@magento create issue

@engcom-Bravo
Copy link
Contributor

engcom-Bravo commented Jun 4, 2024

Hi @yogesh-valiya,

Thanks for the collaboration & contribution!

✔️ QA Passed

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE, WebAPI Tests

@engcom-Charlie
Copy link
Contributor

@engcom-Charlie
Copy link
Contributor

Few test failures in recent 2 runs of functional EE are different. Below 2 failures are constant in both the builds but these are the known issues. Hence moving this PR to Merge in Progress.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/37852/637586a93d6c47f9e43100b6012b9959/Functional/allure-report-ee/index.html#categories
image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/37852/416043f374b5f8029ed4d74b7e125768/Functional/allure-report-ee/index.html#categories
image

Known Issues:

  1. StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest: ACQE-6331
  2. AdminReorderWithCatalogPriceRuleDiscountTest: ACQE-6523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: accept Project: Community Picked PRs upvoted by the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Fix wording of filter item on layered navigation
7 participants