Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/magento2#37107 Replace Deprecated Output Escaping #37982

Merged
merged 3 commits into from
Dec 8, 2023
Merged

magento/magento2#37107 Replace Deprecated Output Escaping #37982

merged 3 commits into from
Dec 8, 2023

Conversation

BeggiNN
Copy link
Contributor

@BeggiNN BeggiNN commented Sep 12, 2023 •
edited
Loading

Description (*)

Refactors the Magento_CatalogWidget module to replace $block escaping functions with $escaper escaping functions.

Fixed Issues (if relevant)

  1. Fixes [Issue] Chore: Catalog Widget - Replace Block Escaping with Escaper #37107

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@BeggiNN
magento#37107 Replace Deprecated Output Escaping
ccf12e8 
- Replace in templates in module Magento_CatalogWidget
@m2-assistant
Copy link

m2-assistant bot commented Sep 12, 2023

Hi @BeggiNN. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 12, 2023
@m2-github-services m2-github-services added Partner: Perspective Studio partners-contribution Pull Request is created by Magento Partner labels Sep 12, 2023
@BeggiNN
Copy link
Contributor Author

BeggiNN commented Sep 12, 2023

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento-automated-testing
Copy link

Failed to run the builds. Please try to re-run them later.

@BeggiNN
Copy link
Contributor Author

BeggiNN commented Sep 12, 2023

@magento run Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@BeggiNN
Copy link
Contributor Author

BeggiNN commented Sep 12, 2023

@magento run WebAPI Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@BeggiNN
Copy link
Contributor Author

BeggiNN commented Sep 14, 2023

@magento run Functional Tests CE, Integration Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@BeggiNN
Copy link
Contributor Author

BeggiNN commented Sep 15, 2023

@magento run Functional Tests CE, Integration Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@sinhaparul sinhaparul added the Project: Community Picked PRs upvoted by the community label Oct 13, 2023
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Hotel engcom-Hotel self-requested a review October 26, 2023 06:20
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Delta engcom-Delta self-assigned this Nov 8, 2023
@engcom-Delta
Copy link
Contributor

@magento run Functional Tests EE

@magento-automated-testing Magento Automated Testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Delta
Copy link
Contributor

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Manual testing scenario:

  1. Verify the deprecated functions in lib/internal/Magento/Framework/View/Element/AbstractBlock.php class
  2. Verify the function defined in lib/internal/Magento/Framework/Escaper.php class

After: ✔️  

In the codebase of the 2.4-develop branch some of the functions are marked as deprecated from the lib/internal/Magento/Framework/View/Element/AbstractBlock.php class and the function defined in class lib/internal/Magento/Framework/Escaper.php with the same name will be used from now

Builds are failed. Hence, moving this PR to Extended Testing.

@engcom-Charlie engcom-Charlie self-assigned this Nov 13, 2023
@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests EE

@magento-automated-testing Magento Automated Testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests EE

@magento-automated-testing Magento Automated Testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Charlie
Copy link
Contributor

The Functional EE test failures are different in recent 2 successive builds. They neither part of PR nor failing because of the PR changes, hence moving it to Merge in Progress.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/37982/06121562520563a27c14a61c90d9f20c/Functional/allure-report-ee/index.html#categories

image

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/37982/66116c6156dcd72c71a66d0c24065894/Functional/allure-report-ee/index.html#categories/6ca9d315ebd9ab54dbe1fb9148ebdc1f/17a9cfbd1ca31362/

image

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit bcb4298 into magento:2.4-develop Dec 8, 2023
11 of 12 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel requested changes

Assignees

@engcom-Charlie engcom-Charlie

@engcom-Delta engcom-Delta

@engcom-Hotel engcom-Hotel

Labels
Partner: Perspective Studio partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Project: Community Picked PRs upvoted by the community
Projects
Community Dashboard
Status: Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Chore: Catalog Widget - Replace Block Escaping with Escaper
8 participants
@BeggiNN @engcom-Hotel @engcom-Delta @engcom-Charlie @sinhaparul @magento-devops-reposync-svc @m2-github-services @glo24157