magento/magento2#37107 Replace Deprecated Output Escaping #37982

BeggiNN · 2023-09-12T08:55:55Z

Description (*)

Refactors the Magento_CatalogWidget module to replace $block escaping functions with $escaper escaping functions.

Fixed Issues (if relevant)

Fixes [Issue] Chore: Catalog Widget - Replace Block Escaping with Escaper #37107

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

- Replace in templates in module Magento_CatalogWidget

m2-assistant · 2023-09-12T08:55:58Z

Hi @BeggiNN. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

BeggiNN · 2023-09-12T08:56:40Z

@magento run all tests

magento-automated-testing · 2023-09-12T08:56:49Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

magento-automated-testing · 2023-09-12T11:12:27Z

Failed to run the builds. Please try to re-run them later.

BeggiNN · 2023-09-12T11:13:00Z

@magento run Functional Tests CE

magento-automated-testing · 2023-09-12T11:13:07Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

BeggiNN · 2023-09-12T12:43:04Z

@magento run WebAPI Tests

magento-automated-testing · 2023-09-12T12:43:11Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

BeggiNN · 2023-09-14T06:55:42Z

@magento run Functional Tests CE, Integration Tests

magento-automated-testing · 2023-09-14T06:55:53Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

BeggiNN · 2023-09-15T06:49:15Z

@magento run Functional Tests CE, Integration Tests

magento-automated-testing · 2023-09-15T06:49:20Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Hotel · 2023-10-26T06:20:19Z

@magento run all tests

magento-automated-testing · 2023-10-26T06:20:32Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Hotel · 2023-10-26T07:27:48Z

@magento run all tests

magento-automated-testing · 2023-10-26T07:27:59Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Hotel · 2023-10-26T09:26:26Z

@magento run Integration Tests

magento-automated-testing · 2023-10-26T09:26:35Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Hotel

Hello @BeggiNN,

Thanks for the contribution!

Please fix the integration test failures, it seems due to these PR changes.

Thanks

engcom-Hotel · 2023-10-31T14:34:23Z

@magento run Functional Tests EE, Functional Tests CE

magento-automated-testing · 2023-10-31T14:34:30Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Hotel · 2023-10-31T17:13:30Z

@magento run Functional Tests EE

magento-automated-testing · 2023-10-31T17:13:39Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Hotel · 2023-11-02T07:15:09Z

The integration test has been clear now. And the Functional Tests EE failure seems flaky to me. Hence moving this PR further.

Thanks

engcom-Delta · 2023-11-08T15:12:55Z

@magento run Functional Tests EE

magento-automated-testing · 2023-11-08T15:13:02Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Delta · 2023-11-10T20:12:42Z

✔️ QA Passed

Preconditions:

Install fresh Magento 2.4-develop

Manual testing scenario:

Verify the deprecated functions in lib/internal/Magento/Framework/View/Element/AbstractBlock.php class
Verify the function defined in lib/internal/Magento/Framework/Escaper.php class

After: ✔️

In the codebase of the 2.4-develop branch some of the functions are marked as deprecated from the lib/internal/Magento/Framework/View/Element/AbstractBlock.php class and the function defined in class lib/internal/Magento/Framework/Escaper.php with the same name will be used from now

Builds are failed. Hence, moving this PR to Extended Testing.

engcom-Charlie · 2023-11-13T06:26:33Z

@magento run Functional Tests EE

magento-automated-testing · 2023-11-13T06:26:42Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Charlie · 2023-11-13T09:13:54Z

@magento run Functional Tests EE

magento-automated-testing · 2023-11-13T09:14:01Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Charlie · 2023-11-13T12:00:01Z

The Functional EE test failures are different in recent 2 successive builds. They neither part of PR nor failing because of the PR changes, hence moving it to Merge in Progress.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/37982/06121562520563a27c14a61c90d9f20c/Functional/allure-report-ee/index.html#categories

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/37982/66116c6156dcd72c71a66d0c24065894/Functional/allure-report-ee/index.html#categories/6ca9d315ebd9ab54dbe1fb9148ebdc1f/17a9cfbd1ca31362/

magento#37107 Replace Deprecated Output Escaping

ccf12e8

- Replace in templates in module Magento_CatalogWidget

m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 12, 2023

m2-github-services added Partner: Perspective partners-contribution Pull Request is created by Magento Partner labels Sep 12, 2023

m2-community-project bot added the Progress: pending review label Sep 12, 2023

sinhaparul added the Project: Community Picked PRs upvoted by the community label Oct 13, 2023

Merge branch '2.4-develop' into fix-for-issue-37107

b92674d

engcom-Hotel self-requested a review October 26, 2023 06:20

m2-community-project bot added Progress: review and removed Progress: pending review labels Oct 26, 2023

engcom-Hotel requested changes Oct 26, 2023

View reviewed changes

m2-community-project bot assigned engcom-Hotel Oct 26, 2023

m2-community-project bot added Progress: ready for testing and removed Progress: needs update labels Nov 2, 2023

engcom-Delta self-assigned this Nov 8, 2023

m2-community-project bot added Progress: needs update and removed Progress: ready for testing labels Nov 8, 2023

engcom-Delta added the Progress: testing in progress label Nov 8, 2023

m2-community-project bot removed the Progress: needs update label Nov 8, 2023

engcom-Delta added Progress: extended testing and removed Progress: testing in progress labels Nov 10, 2023

engcom-Charlie self-assigned this Nov 13, 2023

m2-community-project bot added Progress: needs update Progress: extended testing and removed Progress: extended testing Progress: needs update labels Nov 13, 2023

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Nov 13, 2023

magento-devops-reposync-svc merged commit bcb4298 into magento:2.4-develop Dec 8, 2023

magento/magento2#37107 Replace Deprecated Output Escaping #37982

magento/magento2#37107 Replace Deprecated Output Escaping #37982

Uh oh!

Conversation

BeggiNN commented Sep 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Sep 12, 2023

Uh oh!

BeggiNN commented Sep 12, 2023

Uh oh!

magento-automated-testing bot commented Sep 12, 2023

Uh oh!

magento-automated-testing bot commented Sep 12, 2023

Uh oh!

BeggiNN commented Sep 12, 2023

Uh oh!

magento-automated-testing bot commented Sep 12, 2023

Uh oh!

BeggiNN commented Sep 12, 2023

Uh oh!

magento-automated-testing bot commented Sep 12, 2023

Uh oh!

BeggiNN commented Sep 14, 2023

Uh oh!

magento-automated-testing bot commented Sep 14, 2023

Uh oh!

BeggiNN commented Sep 15, 2023

Uh oh!

magento-automated-testing bot commented Sep 15, 2023

Uh oh!

engcom-Hotel commented Oct 26, 2023

Uh oh!

magento-automated-testing bot commented Oct 26, 2023

Uh oh!

engcom-Hotel commented Oct 26, 2023

Uh oh!

magento-automated-testing bot commented Oct 26, 2023

Uh oh!

engcom-Hotel commented Oct 26, 2023

Uh oh!

magento-automated-testing bot commented Oct 26, 2023

Uh oh!

engcom-Hotel left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-Hotel commented Oct 31, 2023

Uh oh!

magento-automated-testing bot commented Oct 31, 2023

Uh oh!

engcom-Hotel commented Oct 31, 2023

Uh oh!

magento-automated-testing bot commented Oct 31, 2023

Uh oh!

engcom-Hotel commented Nov 2, 2023

Uh oh!

engcom-Delta commented Nov 8, 2023

Uh oh!

magento-automated-testing bot commented Nov 8, 2023

Uh oh!

engcom-Delta commented Nov 10, 2023

✔️ QA Passed

Uh oh!

engcom-Charlie commented Nov 13, 2023

Uh oh!

magento-automated-testing bot commented Nov 13, 2023

Uh oh!

engcom-Charlie commented Nov 13, 2023

Uh oh!

magento-automated-testing bot commented Nov 13, 2023

Uh oh!

engcom-Charlie commented Nov 13, 2023

Uh oh!

Uh oh!

BeggiNN commented Sep 12, 2023 •

edited

Loading