Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fixes some wrong usages of ignoring coding standards in less files. #38012

Draft
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

hostep
Copy link
Contributor

@hostep hostep commented Sep 26, 2023

Description (*)

New Magento coding standards v32 came with fix for ignoring underscore usage in less files, I tried looking to remove some of the ignores that got added in less files over the last couple of months that ran into this false positive.
However, while trying to remove those now obsolete ignores, I ran into a bunch more problems, where I discovered that the syntax //@codingStandardsIgnoreEnd wasn't even working, it should have been used as /* @codingStandardsIgnoreEnd */.
While fixing those, ran into a bunch more problems, like:

I'm considering this WIP, still TODO:

  • compare if the resulting css files contain no changes (or only a few changes and see if those make sense).
  • explain changes in more detail
  • write out manual testing scenario's if resulting css files are different then before

Related Pull Requests

Fixed Issues (if relevant)

  1. None

Manual testing scenarios (*)

  1. Entire frontend should still look identical as before

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Sep 26, 2023

Hi @hostep. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@hostep
Copy link
Contributor Author

hostep commented Sep 26, 2023

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Sep 26, 2023
@hostep hostep changed the title Fixes some wrong usages of ignoring coding standards in less files. [WIP] Fixes some wrong usages of ignoring coding standards in less files. Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Pull Requests Dashboard
  
Pending Review
Development

Successfully merging this pull request may close these issues.

None yet

1 participant