file upload issue in WYSIWYG editor on product page #38025

DhruvBasan · 2023-09-29T11:30:25Z

Title

The folder-tree are not visible and getting error “We can't upload the file to the current folder right now. Please try another folder.” when we try to upload image

Description (*)

There is an issue encountered when attempting to upload an image to a folder within the WYSIWYG editor on a product page, specifically within the short description in content section. The folders are not visible, and as a result, we cannot upload the image and we receive an error message stating, 'We can't upload the file to the current folder right now. Please try another folder.' This problem only occurs when you expand the 'Image and Video' tab first. And getting the error in console as shown in below image

Manual testing scenarios (*)

1: Access the Magento admin panel and navigate to 'Catalog' -> 'Products.' and Select any product.

2: in the product page, first, expand the 'Image and Videos' tab, as shown in the image below.

3: Next, expand the 'Content' tab and in 'Short Description' section click on the 'Insert Image' button and select the 'Source' button in the WYSIWYG editor, as indicated in the image below

4: after clicking the 'Source' button, you may notice that the folders are not displayed, and as a result, you are unable to upload images within the 'Short Description.' as you can see in below image

Expected result

After expanding image and videos tab first we should be able to see folder option and can insert image in short description

Actual result

After expanding image and videos tab first we can not see folder option and can not insert image in short-description

Aditional information

In this issue, when we expand the 'Image and Videos' tab and then attempt to upload an image within the 'Short Description' content section, it triggers the 'tmp.init(el,options);' in the lib/web/jquery/jstree/jquery.jstree.js file at line 123, as illustrated in the image below.

After the 'tmp.init(el, options)' function is triggered in the 'jquery.jstree.js' file, it call the init function in the 'tree-suggest.js' file. Please note that it call init function in the 'tree-suggest.js' file only when we initially expand the 'Image and Videos' tab first.

In the lib/web/mage/backend/tree-suggest.js file, it calls the ‘init’ function at line 58 however, an issue arises because the ‘init’ function does not receive the element. Consequently, ‘this.get_container’ becomes undefined

This issue likely plays a significant role in the failure to display folders in the WYSIWYG editor when attempting to upload an image.the element contains the data of folder-tree so if it not assign correct we can not see folder tree when we try to insert image using WYSIWYG editor in short-description

In the image provided above, you can see on line 77 and also on line 102, there is a call to the '_get_node' method. However, there isn't a method with this name in the file or jquery.jstree.js file. Instead, the correct method name is 'get_node.' Therefore, we need to make this correction to ensure the proper function is called.

Solution

To resolve the issue, we need to make changes in the 'lib/web/mage/backend/tree-suggest.js' file. Specifically, we should pass the 'element' in the 'init' function at line 58. Afterward, we should call the 'init' function before 'get_container' and pass the 'data' (consisting of 'element' and 'option') to ensure that the 'init' function receives the required element. This modification ensures that the 'container' variable is not undefined.

Additionally, we should replace instances of '_get_node' with 'get_node' on lines 77 and 102 to ensure that the correct method is called.

Once these modifications are implemented, the issue should be successfully resolved.you can see changes in below image

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] file upload issue in WYSIWYG editor on product page #38026: file upload issue in WYSIWYG editor on product page

m2-assistant · 2023-09-29T11:30:28Z

Hi @DhruvBasan. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

DhruvBasan · 2023-09-29T11:31:20Z

@magento run Unit Tests

magento-automated-testing · 2023-09-29T11:31:31Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Bravo · 2023-09-29T11:52:40Z

@magento create issue

DhruvBasan · 2023-11-10T10:36:10Z

@magento run all tests

magento-automated-testing · 2023-11-10T10:36:19Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

andrewbess

Hello @DhruvBasan
Thank you for your contribution
Could you please check my suggestions and fix PR
Thank you in advance.

andrewbess · 2024-01-27T22:24:39Z

lib/web/mage/backend/tree-suggest.js

+        init: function (el,options) {
+            init.call(this,el,options);


Let's add spaces between params

Suggested change

init: function (el,options) {

init.call(this,el,options);

init: function (el, options) {

init.call(this, el, options);

Perhaps JS Coding Style requires it
https://javascript.info/coding-style

Hello @andrewbess , I have implemented the suggestions you provided on my pull request

engcom-Hotel · 2024-01-30T05:12:26Z

@magento run all tests

magento-automated-testing · 2024-01-30T05:12:31Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Hotel · 2024-01-30T12:01:08Z

@magento run Functional Tests B2B, Functional Tests EE, Integration Tests, WebAPI Tests

magento-automated-testing · 2024-01-30T12:01:15Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Hotel

Hello @DhruvBasan,

Thanks for the collaboration!

The code changes seems good to us. But in accordance of DOD, please cover the changes with some automated test.

Thanks

engcom-Echo · 2024-02-08T10:41:58Z

WebAPI Tests failure is known failure and not related to PR changes.
Functional Tests CE and Functional Tests B2B failure are different on last two run on same commit.
Functional Tests CE
Run1

Run2

Functional Tests B2B
Run1

Run2

Hence Moving it to Merge In Progress

DhruvBasan · 2024-03-01T05:36:17Z

@engcom-Echo your changes in the test file (app/code/Magento/Cms/Test/Mftf/Section/TinyMCESection/MediaGallerySection.xml) are conflicting with the developer branch. Could you please review and resolve the conflict?

engcom-Echo · 2024-03-01T06:58:11Z

@magento run all tests

engcom-Echo · 2024-03-01T07:49:12Z

@magento run Static Tests

engcom-Echo · 2024-03-01T09:42:10Z

@magento run Static Tests,Integration Tests,Functional Tests CE,Functional Tests B2B

engcom-Echo · 2024-03-04T05:54:30Z

@magento run all tests

engcom-Echo · 2024-03-04T06:46:35Z

@magento run all tests

engcom-Echo · 2024-03-04T07:42:31Z

@magento run all tests

engcom-Echo · 2024-03-04T11:43:20Z

@magento run WebAPI Tests,Functional Tests B2B

engcom-Echo · 2024-03-05T03:08:06Z

@magento run all tests

engcom-Echo · 2024-03-05T05:21:02Z

@magento run Functional Tests EE,Functional Tests B2B,Integration Tests,WebAPI Tests

engcom-Echo · 2024-03-05T06:59:16Z

@magento run Functional Tests EE ,Integration Tests

engcom-Echo · 2024-03-05T07:15:14Z

**Integration Tests ** failure are known flaky failure.

Functional Tests B2B,Functional Tests EE failures are different on last two run on same commit.
Functional Tests B2B
Run1

Run2

Functional Tests EE
Run1

Run2

Hence Moving it to merge in progress

hostep · 2024-05-16T22:42:47Z

Looks like this was merged in 2.4-develop recently in c6bc830

However, PR isn't marked as merged, probably because of the last 2 merge commits part of this PR.
So I guess this PR can be closed?

engcom-Echo · 2024-05-17T00:43:45Z

Closing this PR as it is merged to 2.4-develop. Commit link can be found here

file upload issue in WYSIWYG editor on product page

90d6aed

m2-assistant bot mentioned this pull request Sep 29, 2023

[Issue] file upload issue in WYSIWYG editor on product page #38026

Closed

5 tasks

m2-community-project bot added the Progress: pending review label Sep 29, 2023

engcom-Bravo added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 29, 2023

sinhaparul added the Project: Community Picked PRs upvoted by the community label Jan 25, 2024

andrewbess requested changes Jan 27, 2024

View reviewed changes

m2-community-project bot assigned andrewbess Jan 27, 2024

m2-community-project bot added Progress: needs update and removed Progress: pending review labels Jan 27, 2024

DhruvBasan and others added 2 commits January 29, 2024 12:55

Merge branch 'magento:2.4-develop' into file_upload_error

5c299c6

improve the code as per js coding standard

e272ef1

m2-community-project bot added Progress: review and removed Progress: needs update labels Jan 29, 2024

engcom-Hotel self-requested a review January 30, 2024 05:11

engcom-Hotel requested changes Jan 30, 2024

View reviewed changes

m2-community-project bot assigned engcom-Hotel Jan 30, 2024

m2-community-project bot added Progress: needs update and removed Progress: review labels Jan 30, 2024

engcom-Echo self-assigned this Feb 2, 2024

Added MFTF test coverage

d465a50

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Feb 8, 2024

Resolve conflicts

e26d723

m2-community-project bot added Progress: extended testing and removed Progress: accept labels Mar 1, 2024

Merge branch '2.4-develop' into file_upload_error

28ad01f

Static test failure fixed caused due to identation

ff557b9

Static test failure fixed caused due to identation

4500111

Merge branch '2.4-develop' into file_upload_error

2217c69

m2-community-project bot added Progress: accept and removed Progress: extended testing labels Mar 5, 2024

DhruvBasan added 2 commits April 1, 2024 16:37

Merge branch 'magento:2.4-develop' into file_upload_error

9583cac

Merge branch '2.4-develop' into file_upload_error

3d00e0a

engcom-Echo closed this May 17, 2024

m2-community-project bot removed the Progress: accept label May 17, 2024

file upload issue in WYSIWYG editor on product page #38025

file upload issue in WYSIWYG editor on product page #38025

Conversation

DhruvBasan commented Sep 29, 2023 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Title

Description (*)

Manual testing scenarios (*)

**Expected result **

**Actual result **

Aditional information

Solution

Questions or comments

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Sep 29, 2023

Uh oh!

DhruvBasan commented Sep 29, 2023

Uh oh!

magento-automated-testing bot commented Sep 29, 2023

Uh oh!

engcom-Bravo commented Sep 29, 2023

Uh oh!

DhruvBasan commented Nov 10, 2023

Uh oh!

magento-automated-testing bot commented Nov 10, 2023

Uh oh!

andrewbess left a comment

Choose a reason for hiding this comment

Uh oh!

andrewbess Jan 27, 2024

Choose a reason for hiding this comment

Uh oh!

DhruvBasan Jan 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

engcom-Hotel commented Jan 30, 2024

Uh oh!

magento-automated-testing bot commented Jan 30, 2024

Uh oh!

engcom-Hotel commented Jan 30, 2024

Uh oh!

magento-automated-testing bot commented Jan 30, 2024

Uh oh!

engcom-Hotel left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-Echo commented Feb 8, 2024

Uh oh!

DhruvBasan commented Mar 1, 2024

Uh oh!

engcom-Echo commented Mar 1, 2024

Uh oh!

engcom-Echo commented Mar 1, 2024

Uh oh!

engcom-Echo commented Mar 1, 2024

Uh oh!

engcom-Echo commented Mar 4, 2024

Uh oh!

engcom-Echo commented Mar 4, 2024

Uh oh!

engcom-Echo commented Mar 4, 2024

Uh oh!

engcom-Echo commented Mar 4, 2024

Uh oh!

engcom-Echo commented Mar 5, 2024

Uh oh!

engcom-Echo commented Mar 5, 2024

Uh oh!

engcom-Echo commented Mar 5, 2024

Uh oh!

engcom-Echo commented Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hostep commented May 16, 2024

Uh oh!

engcom-Echo commented May 17, 2024

Uh oh!

DhruvBasan commented Sep 29, 2023 •

edited by m2-assistant bot

Loading

Expected result

Actual result

DhruvBasan Jan 29, 2024 •

edited

Loading

engcom-Echo commented Mar 5, 2024 •

edited

Loading