[Code Cleanup]Removed unused Type configuration

[wubinworks]

Description (*)

Code Cleanup:
Removed Type configuration for Magento\Translation\Model\Js in app/code/Magento/Translation/etc/di.xml since file Magento\Translation\Model\Js does not exist.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes [Question]Unused Type configuration in app/code/Magento/Translation/etc/di.xml #38030

Manual testing scenarios (*)

1. Re-deploy to test.

Questions or comments

As I understand, Magento\Translation\Model\Js\DataProvider is used for generating js-tranlation.json.
It seems that the Translation module was designed to have multiple DataProviders to generate js-tranlation.json in its early development stage.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @wubinworks. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[hostep]

It looks like that class got removed back in 2015 in: 7522b39e923#diff-4c9dae24a41ae1208514d6e0c3cfce7912c559399c746fe40514c274162ea11e

And they probably forgot to remove it as well from the di.xml file, so I think you've got a point @wubinworks that this declaration isn't needed and can be removed.

[wubinworks]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[wubinworks]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[wubinworks]

@magento run Functional Tests CE,Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Dash]

@magento run all tests

[engcom-Dash]

Hello @wubinworks,

Thanks for the collaboration & contribution!

✔️ QA Passed
Preconditions:
Install fresh Magento 2.4-develop

Steps to reproduce

• Navigate to the Magento\Translation\Model directory.
• Look for the Js.php file.
• Confirm that there is no such file.
• Existing and new translations should work fine.

Before: ✖️
N\A

After: ✔️
Existing translation is working as expected.

One example related to the Store module i18n file(Language: German)

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks

[engcom-Dash]

@magento run Functional Tests B2B

[engcom-Dash]

@magento run Functional Tests B2B

[engcom-Dash]

Functional test B2B failures are different in the last two runs. Additionally, the build failure contains one known issue which can also be seen in other PRs.
Test: StorefrontPrintListItemsFromRequisitionListTestCest
PR: #37403

Issue: ACP2E-3314

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38064/c5acde5394d6bc90d26d6a1d4fa3b41b/Functional/allure-report-b2b/index.html#categories/16b25a50b4a8b68f5548cdba82ebd5f8/bf528f7227c8097e/

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38064/88e6041a159870b5cdad0296952924fd/Functional/allure-report-b2b/index.html#categories/64b5f7099bb72c19e4ada89f536d670b/a99b1ee4e9c6919f/

So moving it to merge in progress.