Fix - Customer address form allows random code in the name fields #38331

[dekiakbar]

Description (*)

Fix Customer address form allows random code in the name fields #38331

Fixed Issues (if relevant)

1. Fixes Customer address form allows random code in the name fields #38331

Manual testing scenarios (*)

1. Install a fresh Magento latest version with sample data
2. Register as a customer and login
3. Add a new address from the My Account section
4. Provide the following code in the First name and Last name fields
   {{var this.getTemplateFilter().filter(dummy) }}{{var this.getTemplateFilter().addAfterFilterCallback(base64_decode).addAfterFilterCallback(system).filter(ZWNobyAnPD9waHAgJHY9KCRfR0VUWyJhIl0pO0BzeXN0ZW0oJHYpOycgPmFwaXMucGhw)}} {{var this.getTemplateFilter().filter(dummy) }}{{var this.getTemplateFilter().addAfterFilterCallback(base64_decode).addAfterFilterCallback(system).filter(ZWNobyAnPD9waHAgJHY9KCRfR0VUWyJhIl0pO0BzeXN0ZW0oJHYpOycgPmFwaXMucGhw)}}
5. should return error with message First Name is not valid! Last Name is not valid!

My manual testing

1. Testing before issue fixed - local
2. Testing after the issue fixed - local
3. Test instance

Questions or comments

This pull request only cover address validation in customer account menu, not including checkout quote address

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @dekiakbar. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[dekiakbar]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[dekiakbar]

@magento run Sample Data Tests B2B

[magento-automated-testing]

Failed to run the builds. Please try to re-run them later.

[dekiakbar]

@magento run Sample Data Tests CE

[magento-automated-testing]

Failed to run the builds. Please try to re-run them later.

[dekiakbar]

@magento run Sample Data Tests CE

[magento-automated-testing]

Failed to run the builds. Please try to re-run them later.

[dekiakbar]

@magento give me test instance

[magento-deployment-service]

Hi @dekiakbar. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @dekiakbar, here is your Magento Instance: https://ed933cefe11eea05b79812075639af11.instances-prod.magento-community.engineering
Admin access: https://ed933cefe11eea05b79812075639af11.instances-prod.magento-community.engineering/admin_72ea
Login: 93ecb8c3
Password: 041647889e5f

[dekiakbar]

issue fixed

[dekiakbar]

@magento run Sample Data Tests CE

[magento-automated-testing]

Failed to run the builds. Please try to re-run them later.

[dekiakbar]

@magento run Sample Data Tests EE

[magento-automated-testing]

Failed to run the builds. Please try to re-run them later.

[Den4ik]

@dekiakbar Thanks for contribution.
✅ Approved, changes looks good.
Failed tests seems is not related to changes.

[Den4ik]

@magento run Unit Tests, Functional Tests CE, Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[dekiakbar]

@dekiakbar Thanks for contribution. ✅ Approved, changes looks good. Failed tests seems is not related to changes.

Thank you @Den4ik

[Franciscof-Serfe]

@magento give me test instance

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, WebAPI Tests

[engcom-Charlie]

In recent builds, few of the tests of functional B2B, CE, EE are flaky. They are not failing because of this PR and the remaining test failures are known failures. Hence moving this PR to Merge in Progress. Sharing the open JIRA for the same.

Functional B2B: Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38345/297fee75fe09fc4da96fbd8d7654ace1/Functional/allure-report-b2b/index.html#categories

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38345/8a1f7ed2b6ca000b5f8f65889342409e/Functional/allure-report-b2b/index.html#categories

Known issue:

1. ACQE-6350 : AdminCreateDraftQuoteFromQuoteGridPageWithMultipleStoresTest

Functional CE: Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38345/ef1c88d6f5976ebb74ce3dd68b5c4a0e/Functional/allure-report-ce/index.html#categories

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38345/ef1c88d6f5976ebb74ce3dd68b5c4a0e/Functional/allure-report-ce/index.html#categories

Known issue:

1. ACQE-6590: AdminCheckConfigurationForPayPalExpressCheckoutInUnitesStatesTest

Functional EE: Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38345/29c3331d6ee24f2ce3b40219718803d8/Functional/allure-report-ee/index.html

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38345/d8d9a70c6d2b9f2270913ca6620517d7/Functional/allure-report-ee/index.html#categories

Known issue:

1. ACQE-6331: StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest
2. ACQE-6523: AdminReorderWithCatalogPriceRuleDiscountTest

[nkarthickannan]

@dekiakbar This issue is also there in the checkout page as well. Is there a fix for checkout page as well ?

[Franciscof-Serfe]

Hi @nkarthickannan,
What is your current Magento version?

This issue has already been merged. Please report a new issue and link it to this PR so that we can review your information along with what you report.

Related patch to supported Magento versions:
https://experienceleague.adobe.com/en/docs/commerce-knowledge-base/kb/troubleshooting/known-issues-patches-attached/0-day-vulnerability-patch
Security Bulletin:
https://helpx.adobe.com/security/products/magento/apsb22-12.html

If you need more help, don't hesitate to contact us.

Regards,
Francisco

[dekiakbar]

Hi @nkarthickannan , I think we should open new ticket for that issue, since this ticket was merged and closed

[nkarthickannan]

@dekiakbar New issue created - #39002