Remove scope resolver usage

[thomas-kl1]

Description (*)

Admin URL settings is global and shouldn't be loaded depending of the current store.

Resolved issues:

1. resolves [Issue] Remove scope resolver usage #38566: Remove scope resolver usage

[m2-assistant]

Hi @thomas-kl1. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Hotel]

@magento create issue

[thomas-kl1]

I've noticed this issue while I was looking for current store resolution in the code trace stack.
The scope resolution is done too early.

[thomas-kl1]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @thomas-kl1,

Thanks for the contribution!

It seems the tests are failing due to code changes, please fix them and also cover the changes with some automated tests.

Thanks

[engcom-Dash]

@magento run all tests

[engcom-Dash]

Fixed failing unit test cases so moving this back to pending review.

[engcom-Dash]

Hello @thomas-kl1 ,

Thank you for your contribution!

I wanted to let you know that I can’t proceed with testing your changes at the moment because I’m facing an issue. When using the admin custom URL, it redirects to a 404 page. Once this issue is resolved, I’ll be able to test your changes.

Just wanted to keep you in the loop.

Thanks again!

[engcom-Dash]

@thomas-kl1 I have pushed a commit to resolve the conflicts. I am able to test the changes after adding custom admin URL and custom admin path. The default scope is used now

Thanks

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@thomas-kl1 Thank you for contribution!

✔️ QA Passed

Preconditions:
Install fresh magento 2.4-develop

Steps to reproduce
According to the PR description.

Before:
As per PR description the store scope was getting passed to the admin URL and it should not be loaded depending on the current store.

After: The default scope is used now for custom admin URL

Storefront:

Admin (With custom path & URL):

Some of the test cases are failing hence moving this PR to Extended Testing.

Thank You!

[engcom-Dash]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Unit Tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Unit Tests

[engcom-Dash]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

[engcom-Dash]

In the recent builds for functional EE & CE the constant test case failures are known issues and JIra issues are logged for the same.

Functional EE:

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38554/a5b229d6e24c7a99a26ff816562a0fe4/Functional/allure-report-ee/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38554/6c94fed22d12a39ebc67829f048151f1/Functional/allure-report-ee/index.html#categories

Known Issues:

StorefrontVerifySearchTermEntityRedirectTest: ACQE-7705

Functional CE:

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38554/bd4a19a31973e4fc56646dd63e2911d2/Functional/allure-report-ce/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38554/cf116c7e77dd34c9914c2fa24ba33e12/Functional/allure-report-ce/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Known Issues:

StorefrontVerifySearchTermEntityRedirectTest: ACQE-7705
AdminUserApplyToSeveralSimpleProductsMassActionUnAssignProductSourcesOnProductsGridToUnAssignAllAssignedSourcesTest: ACQE-7706
AdminValidateSimpleProductWithCustomOptionsDragNDropPerPageTest: ACQE-7707

Functional B2B: The consistent test failure has JIra raised for it others consistent failures are not related to changes done in this PR.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38554/f48a486b8b86f9f1d08b96e845603b04/Functional/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/38554/c12befe21450e704c22303d235e40c6f/Functional/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Known Issue:

StorefrontVerifySearchTermEntityRedirectTest: ACQE-7705
StorefrontMergingShoppingCartsFromCheckoutShippingPageTest: ACQE-7568

Hence Moving this PR to Merge In Progress.