magento/magento2#32990: Date and Time Format for Custom Option Not Working

[NitrogenUA]

Description (*)

Fixed Catalog Date & Time Custom Options not honoring Date Fields Order when JS calendar is used.

Fixed Issues (if relevant)

1. Fixes Date and Time Format for Custom Option Not Working #32990

Manual testing scenarios (*)

1. In admin panel under Stores -> Configuration -> Catalog -> Date & Time Custom Options configure Date Fields Order.
2. Modify any product by adding a Customizable Option of Date type.
3. On frontend verify that observed custom option date of that product matches configuration from step 1.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @NitrogenUA. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[NitrogenUA]

@magento run all tests

[NitrogenUA]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @NitrogenUA,

Thanks for your contribution!

The changes look good to me. However, please cover the changes with some automated tests in accordance with the Definition of Done (DOD).

Thanks

[engcom-November]

I have added MFTF test coverage.

[engcom-November]

@magento run all tests

[engcom-Hotel]

@magento run Database Compare, Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests

[engcom-Hotel]

Hello @engcom-November,

Please made the changes as per our discussion.

Thanks

[engcom-Hotel]

@magento run all tests

[engcom-Bravo]

Hi @NitrogenUA,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Steps to reproduce

• In admin panel under Stores -> Configuration -> Catalog -> Date & Time Custom Options configure Date Fields Order.
• Modify any product by adding a Customizable Option of Date type.
• On frontend verify that observed custom option date of that product matches configuration from step 1.

Before: ✖️ 

After: ✔️

Verified all the Different Combinations.Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

[engcom-November]

@magento run all tests

[engcom-November]

@magento run Functional Tests B2B, Functional Tests EE

[engcom-November]

The repeating failure in Functional Tests B2B and Functional Tests EE are falky and known issues.

Functional Tests B2B
Run 1:

Run 2:

Known issues:
ACQE-6801 - StorefrontCheckoutProcessForQuoteWithoutNegotiatedPricesTest

Functional Tests EE
Run 1:

Run 2:

Known issues:
ACQE-6331 - StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest

Hence moving this to Merge in prrogress.