Skip to content

ISSUE-38593 - Fix to save middle name in the quote for guest #39067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 17, 2025
Merged

ISSUE-38593 - Fix to save middle name in the quote for guest #39067

merged 10 commits into from
Feb 17, 2025

Conversation

srsathish92
Copy link
Contributor

Description (*)

Fix to save the customer's middle name in the quote/order table for the guest checkout

Related Pull Requests

NA

Fixed Issues (if relevant)

  1. Fixes middlename('s) not saved for guest accounts #38593

Manual testing scenarios (*)

  1. Place guest order with middle name.
  2. Verify the quote table whether the "customer_middlename" column is filled or not.

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Aug 20, 2024

Hi @srsathish92. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Aug 20, 2024
@m2-github-services m2-github-services added Partner: ITG Commerce partners-contribution Pull Request is created by Magento Partner labels Aug 20, 2024
@srsathish92 srsathish92 changed the title ISSUE-38593 - Fix to save middle name in the quote for quest ISSUE-38593 - Fix to save middle name in the quote for guest Aug 20, 2024
@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Dec 11, 2024
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel engcom-Hotel self-requested a review December 13, 2024 06:18
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE, Functional Tests CE, Integration Tests

engcom-Hotel
engcom-Hotel requested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @srsathish92,

Thanks for the collaboration!

The changes look good to us. However, please include automated tests covering the changes as per the Definition of Done (DoD).

Thanks

@engcom-Dash engcom-Dash self-assigned this Dec 17, 2024
@engcom-Dash
Copy link
Contributor

Hello @srsathish92,

Thanks for the collaboration!

The changes look good to us. However, please include automated tests covering the changes as per the Definition of Done (DoD).

Thanks

I'm working on it.

cc: @srsathish92

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Static Tests

@engcom-Dash
Copy link
Contributor

@magento run Static Tests, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

@engcom-Hotel: I have covered the changes with unit tests. Additionally, I have fixed the static failures, so I am moving it back to pending review.

@engcom-Bravo
Copy link
Contributor

@magento run all tests

@engcom-Bravo
Copy link
Contributor

Hi @srsathish92,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

  • Place guest order with middle name.
  • Verify the quote table whether the "customer_middlename" column is filled or not.

Before: ✖️ 

Screenshot 2024-12-19 at 10 02 10 am

After: ✔️

Screenshot 2024-12-19 at 10 08 40 am

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@engcom-Dash
Copy link
Contributor

@magento run Integration Tests, Functional Tests EE, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

The Functional B2B test failure is inconsistent in the last two builds and seem to be flaky. They neither part of PR nor failing because of the PR changes, hence moving it to Merge in Progress.

Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39067/438b375dbcb807c78bd5913427b45fe3/Functional/allure-report-b2b/index.html#categories/7441e147742cc9294f4ce2a0b5090c42/2117aaff39bc5c43/
image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39067/ba6f5b6b90a68a4aa089aae9ecc1b512/Functional/allure-report-b2b/index.html#categories/2fc037f47773dd7551f2e766bbf34efa/b266ec312127147f/
image

@engcom-Charlie
Copy link
Contributor

As the PR is having conflicts, moving it to Extended Testing.

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento all tests

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Unit Tests, Integration Tests, Functional Tests EE, Functional Tests CE

@engcom-Dash
Copy link
Contributor

The Functional CE, EE and Integration test failures are inconsistent or known issues in the last two builds and seem to be flaky. They neither part of PR nor failing because of the PR changes, hence moving it to Merge in Progress.

Integration Tests
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39067/00e88de9855f87b0344ac5c9a3c2ff55/Integration/console-error-logs.html
image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39067/20ecb2fb12b79ffcea95f901cf5dd19e/Integration/console-error-logs.html
image

Known Issue:
AC-13584

Functional Tests CE
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39067/ed1a85389eb50587b7c0a63c60cb23f8/Functional/allure-report-ce/index.html#categories/75b40a63f79830217aae704c6d6af940/949221b1e68f9003/
image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39067/5a9f52b1d296a7c6ebfd32a10e18646a/Functional/allure-report-ce/index.html#categories/e93c564a2dcd5e30ee0e0e811a828c2b/b231fcb0ae617645/
image

Known Issues:
StorefrontCreateCustomerWithInvalidDataTest: AC-13608
StoreFrontAddOutOfStockProductToShoppingCartTest: ACQE-6818

Functional Tests EE
Run 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39067/58e8a25158f1a7df6eec0c3320ac2989/Functional/allure-report-ee/index.html#categories/248597673789965e9aa9f3e68e4329b7/6e7bae3c5c99780f/
image

Run 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39067/22e90edd145dd4e214a7fcb5c3e9bfae/Functional/allure-report-ee/index.html#categories/75b40a63f79830217aae704c6d6af940/5c7498f2b504e4a0/
image

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 281cfc3 into magento:2.4-develop Feb 17, 2025
9 of 12 checks passed
@srsathish92 srsathish92 deleted the issue-38593 branch February 21, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel approved these changes

Assignees

@engcom-Hotel engcom-Hotel

@engcom-Dash engcom-Dash

Labels
Partner: ITG Commerce partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Project: Community Picked PRs upvoted by the community
Projects
Community Dashboard
Status: Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

middlename('s) not saved for guest accounts
8 participants
@srsathish92 @engcom-Hotel @engcom-Dash @engcom-Bravo @engcom-Charlie @magento-devops-reposync-svc @m2-github-services @Priyakshic