Skip to content

fix UPS rest api error handling #40111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from
Open

fix UPS rest api error handling #40111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/code/Magento/Ups/Model/Carrier.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1200,10 +1200,10 @@ function () use ($httpResponse, $debugData) {
$debugData['result'] = ['error' => $e->getMessage(), 'code' => $e->getCode()];
$this->_logger->critical($e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also refactor this logger, as it logs really messy context in the log. Instead, I'd go:

$this->_logger->critical('UPS Exception: ' . $e->getMessage(), [
    'trace' => $e->getTrace(),
    'payload' => $ratePayload
]);

That gives you enough information for debugging and the usage of 2nd argument (array $context) gives you the context of an event.

}
if ($responseResult) {
$jsonResponse = $responseResult->getStatusCode() >= 400 ? '' : $responseResult->getBody();
if ($responseResult && ($responseResult->getStatusCode() < 400)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not need additional parenthesis.

Suggested change
if ($responseResult && ($responseResult->getStatusCode() < 400)) {
if ($responseResult && $responseResult->getStatusCode() < 400) {

$jsonResponse = $responseResult->getBody();
$debugData['result'] = $jsonResponse;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When it's HTTP 401 / 503 etc. - Your solution does not give any debug information.

}
$debugData['result'] = $jsonResponse;
$this->_debug($debugData);

return $this->_parseRestResponse($jsonResponse);
Expand Down