-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix: getSalableVariantsByParent hook up cataloginventory/options/show_out_of_stock setting #40175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
Fix: getSalableVariantsByParent hook up cataloginventory/options/show_out_of_stock setting #40175
Conversation
…tSalableVariantsByParent
Hi @ThisIsRuddy. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email psirt@adobe.com. |
Signed Adobe CLA |
The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email psirt@adobe.com. |
@magento run all tests |
@magento run all tests |
Since updating the copyright message, the only tests failing seem to be from other commits outside the remit of this PR. |
@magento create issue |
The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email psirt@adobe.com. |
Issue
The function
getSalableVariantsByParent
does not abide by the admin settingcataloginventory/options/show_out_of_stock
When OOS is set to Yes, the resolver does not return OOS variants.
Resolution
Load in config scope interface and pull value and apply to filters
Debug/Replication
Toggle show/hide oos items via magento admin config and check results contain stock_status = OUT_OF_STOCK or not
Select some options and check variant results abides by admin setting
(patch attached for convinence)
magento-module-configurable-product-graph-ql-get-available-selections.patch
Resolved issues: