Skip to content

Conversation

GrimLink
Copy link
Member

@GrimLink GrimLink commented Sep 8, 2025

This fixes the incorrect autocomplete values in Admin Account Settings, as explained in issue #40179

Description (*)

This adds the missing HTML autocomplete attributes to the password fields.

Fixed Issues

  1. Fixes Incorrect autocomplete values in Admin Account Settings #40179

Manual testing scenarios (*)

  1. Got to the Magento 2 admin page.
  2. Navigate to the Admin User Setting
  3. In this form you will see that the autocomplete value for the new-password is set using autocomplete

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
    While the tests fail, this not related to this PR.

Copy link

m2-assistant bot commented Sep 8, 2025

Hi @GrimLink. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@ct-prd-pr-scan
Copy link

ct-prd-pr-scan bot commented Sep 8, 2025

The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email psirt@adobe.com.

@GrimLink GrimLink changed the title ADD: missing autocomplete values for passwords FIX: missing autocomplete values for passwords Sep 8, 2025
@ct-prd-pr-scan
Copy link

ct-prd-pr-scan bot commented Sep 8, 2025

The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email psirt@adobe.com.

@GrimLink
Copy link
Member Author

GrimLink commented Sep 8, 2025

@magento run all tests

@ct-prd-pr-scan
Copy link

ct-prd-pr-scan bot commented Sep 8, 2025

The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email psirt@adobe.com.

1 similar comment
@ct-prd-pr-scan
Copy link

ct-prd-pr-scan bot commented Sep 8, 2025

The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email psirt@adobe.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect autocomplete values in Admin Account Settings
1 participant