Wrapped 'element' with jQuery #4022
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When is this going to be merged into develop? I'm having this issue with our in-development Magento 2 store. |
|
Once Travis CI build will show green status, this will be merged. Sorry guys, for us being silent for awhile. |
|
@vkorotun can you specific what needs to be done to make sure travis runs are green? The fork needs to be updated? anything else? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug when you have an iFrame on the page.
This is caused by the fact that element is not wrapped in jQuery when the function is called recursively. The easiest and most likely fix is simply to wrap the element in jQuery when working with iFrames.