Skip to content

Loading…

Fix issue with Mage/GoogleCheckout reference in Mage/Sales module #61

Closed
wants to merge 1 commit into from

2 participants

@IvanChepurnyi

Currently if you disable Mage/GoogleCheckout module, during checkout process there will be a fatal error since payment model of google checkout module that is marked as active gets retrieved. It is wrong behavior, since sales module shouldn't depend on a particular payment method.

The following pull request contain proper fix of that issue.

@magento-team

@IvanChepurnyi, thank you for the fix. You're right, that Sales module shouldn't depend on GoogleCheckout module.
Unfortunately we couldn't reproduce fatal error on checkout process with disabled GoogleCheckout module.
Could you provide more detailed test case with steps and actual result?

@IvanChepurnyi

Please remove Mage/GoogleCheckout module at all and then you will get a fatal error.

@magento-team

@IvanChepurnyi , thank you for the test case. You are right, it's reproduced if only Mage_GoogleCheckout module is removed.
The issue is fixed and will be available on GitHub with one of the next updates.
Also a test was added, which verifies all payment methods are declared in appropriate modules.

@magento-team magento-team added a commit that referenced this pull request
@magento-team magento-team Update as of 9/13/2012
* Implemented the option to enable the single store mode in the system configuration, which simplifies the back-end GUI:
  * Hiding scope labels from the system configuration
  * Hiding the scope switcher from the CMS management pages and the system configuration
  * Hiding scope related fields from the system configuration
  * Hiding scope related columns and fields from the sales pages (order, invoice, shipment pages)
  * Hiding scope related fields from the promotions
  * Hiding scope related fields from the catalog pages
  * Hiding scope related columns and fields from the customers management page
  * Hiding scope related columns and fields from the customer and customer address attributes management pages
* Implemented the history management for the Visual Design Editor
* Implemented the user interface for themes management, which allows to list existing themes and add new ones
* Replaced all usages of the old JavaScript translations mechanism with the new jQuery one
* Refactored methods with high cyclomatic complexity
* Converted some surrogate integration tests into functional Selenium tests
* Converted some surrogate integration tests into unit tests
* Fixes:
  * Fixed inability to install application with a prefix defined for database tables
  * Fixed displaying fields with model name in the payment methods settings
  * Fixed performance degradation of the back-end menu rendering
  * Fixed absence of the success message upon newsletter template creation/deletion/queueing
  * Workaround for occasional segmentation fault in integration tests caused by `Mage_Core_Model_Resource_Setup_Migration`
* GitHub requests:
  * [#51](#51) -- fixed managing of scope-spefic values for Categories
  * [#56](#56) -- removed excessive semicolon in the CSS file
  * [#60](#60) -- fixed taking bind parameters into account in `Mage_Core_Model_Resource_Db_Collection_Abstract::getAllIds()`
  * [#61](#61) -- relocated declaration of the "Google Checkout" payment method into `Mage_GoogleCheckout` module from `Mage_Sales`
da072ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Showing with 1 addition and 5 deletions.
  1. +1 −0 app/code/core/Mage/GoogleCheckout/etc/config.xml
  2. +0 −5 app/code/core/Mage/Sales/etc/config.xml
View
1 app/code/core/Mage/GoogleCheckout/etc/config.xml
@@ -131,6 +131,7 @@
<googlecheckout>
<active>1</active>
<model>Mage_GoogleCheckout_Model_Payment</model>
+ <title>Google Checkout</title>
</googlecheckout>
</payment>
<google>
View
5 app/code/core/Mage/Sales/etc/config.xml
@@ -1451,11 +1451,6 @@
</adminhtml>
<default>
<payment>
- <googlecheckout>
- <active>1</active>
- <model>Mage_GoogleCheckout_Model_Payment</model>
- <title>Google Checkout</title>
- </googlecheckout>
</payment>
<sales>
<totals_sort>
Something went wrong with that request. Please try again.