Fix grunt prod task and add postcss
#6233
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iazel please update your branch with the latest develop |
|
Closing this PR due to inactivity |
magento-engcom-team
pushed a commit
that referenced
this pull request
Oct 20, 2020
[CIA] Filter fields allowing HTML
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
prod:<theme>grunt task is broken, but this PR fix it.I also add
postcssfor autoprefix and minification (throughcssnano). I configured nano with sensible default, but let me know if you prefer other some other options. Because it is meant for production only, I also suppressed the map creation.Cheers