Removed duplicate code from template file #7220
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only difference is this file is "active: true". It's not neccessary to copy the complete file for it and use the same code twice. Changed this so that only the difference is between an if statement. This results in cleaner code.
|
Hi, @dverkade! |
|
Hi, @dverkade ! |
|
Don't close this issue. It's fixed in the lastest commit of the patch-15 branch and should be accepted. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Nov 16, 2021
[Platform Health] Updates for PHP8.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only difference is this file is "active: true". It's not neccessary to copy the complete file for it and use the same code twice. Changed this so that only the difference is between an if statement. This results in cleaner code.