Replace class-like name in catalog-search/./di.xml

[flancer64]

There is an error in compilation process:

$ ./bin/magento deploy:mode:set production
Enabled maintenance mode
Starting compilation
Something went wrong while compiling generated code. See the error log for details.
Command returned non-zero exit code:
`/usr/bin/php7.0 -f /.../bin/magento setup:di:compile`

if some module's di.xml contains decorator (interceptor) for virtual type Magento\Catalog\Model\ResourceModel\Product\CollectionFactory

<!-- Interceptor to get error with full-text search -->
<type name="Magento\Catalog\Model\ResourceModel\Product\CollectionFactory">
	<plugin name="flancer32_sample_plugin"
			type="Flancer32\Sample\Plugin\Catalog\Model\ResourceModel\Product\CollectionFactory"
			sortOrder="100"
			disabled="false"/>
</type>

This is an error from log:

[RuntimeException]                                                                                                                                                                               
Source class "\Magento\CatalogSearch\Model\ResourceModel\Fulltext\SearchCollection" for "Magento\CatalogSearch\Model\ResourceModel\Fulltext\SearchCollectionFactory" generation does not exist. 

We should rename original virtual type Magento\Catalog\Model\ResourceModel\Product\CollectionFactory to smth like virtualFulltextCollectionFactory to enable production mode compilation.

[flancer64]

This issue is related to PR-6096

[vrann]

@flancer64 it looks like the problem is that some module added plugin for the virtual type. Why would it do that?

[flancer64]

Why would it do that?

@vrann , I needed to modify Product Collection query in my case. So, I have created plugin for the collection's factory.

[vrann]

@flancer64 I think you hit the bug in Magento which does not allow to add the plugin on Virtual Type. It is going to bee fixed in upcoming releases. But so far, the naming convention fro the virtual types is to use fully-qualified class names: https://community.magento.com/t5/Magento-DevBlog/Virtual-Types-Naming-Convention/ba-p/61510

Please comment there to affect this decision.