Prevent overwriting grunt config #8910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @Igloczek. Your issue already solved in Magento. What you need to do:
But, I just find the issue that dev/tools/grunt/configs/local-themes.js and grunt-config.json absent in .gitignore file. Kindly ask you to add these files to .gitignore in current pull request. Thanks. |
|
Makes sense. I reverted my previous changes and push that one recommended by you. |
|
@Igloczek Thanks for the quick fix! |
ishakhsuvarov
approved these changes
Mar 16, 2017
|
@Igloczek thank you for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default Magento stores sample configs as go to config. Any update will overwrite config files added by users.
I simply rename config file to be
*.sampleand add previous one to gitignore, same way aspackage.jsonandgruntfile.js.Fixed Issues
It's a fix for #7196.