magento/magento2#8607: Interface constructor if present will break Magento compilation

[LoganayakiK]

Description

$class->isInterface() method of an php reflection class will implement the getConstructor() function not to pull any dependencies from the interface constructor.
So we must have to add this condition in order to call getConstructor(). This solves the issue

Fixed Issues (if relevant)

1. Interface constructor if present will break Magento compilation #8607: Interface constructor if present will break Magento compilation

Manual testing scenarios

1. Will be covered with unit test

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[adragus-inviqa]

Could you fix the code style to be something like this?

if ($class->isInterface() || 
    !$class->getFileName() || 
    false == $class->hasMethod('__construct') || 
    !$inherited && 
    $class->getConstructor()->class != $class->getName()
) {
    return $output;
}

It looks awful atm.

[okorshenko]

@LoganayakiK thank you for your contribution. Could you please cover the fix with unit test?

[LoganayakiK]

Hi Oleksii, Good day ! I will do the unit test. Could you please share me the book details that you have shared me on friday? If so that would be helpful for me to understand and do well in a right way. Thanks in advance. Regards, Loganayaki Kathirvel

…

On 9 May 2017 11:56 pm, "Oleksii Korshenko" ***@***.***> wrote: @LoganayakiK <https://github.com/LoganayakiK> thank you for your contribution. Could you please cover the fix with unit test? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9524 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AbEyH5L176GmYdZOVxxY1CzRtXpV6E8iks5r4K_FgaJpZM4NRuOt> .

[okorshenko]

@LoganayakiK Try this book: Test Driven Development: By Example (author Kent Beck). This is good book to start

[magento-team]

@LoganayakiK thank you for your contribution to Magento 2 project