Backport of MAGETWO-59256 for 2.1: Custom composer modules break Component Manager #6718 #9692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento#6718 (cherry picked from commit fc99447) MAGETWO-59256: [GitHub] Custom composer modules break Component Manager magento#6718 (cherry picked from commit a9697c6) MAGETWO-59256: [GitHub] Custom composer modules break Component Manager magento#6718 (cherry picked from commit 7352b7c) MAGETWO-59256: [GitHub] Custom composer modules break Component Manager magento#6718 (cherry picked from commit e871276) MAGETWO-59256: [GitHub] Custom composer modules break Component Manager magento#6718 (cherry picked from commit 01f1f42) MAGETWO-59256: [GitHub] Custom composer modules break Component Manager magento#6718 (cherry picked from commit e072d65)
|
|
|
@shiftedreality Could you take a look at this? In reference to #6718 which you closed. |
|
@JTimNolan thanks for pointing this. |
|
@shiftedreality @maghamed Do we have an ETA for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of issue MAGETWO-59256 for 2.1
Cherry picked commits from develop, rebased, and squashed. Then removed some code from farther up the branch to make compatible with 2.1
First time making a PR for this so if I need to make changes/fix let me know.
Commits from the develop branch:
Fixed Issues (if relevant)
Manual testing scenarios