Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved error logging when trying to save a product #9890

Merged
merged 2 commits into from
Jun 9, 2017
Merged

Improved error logging when trying to save a product #9890

merged 2 commits into from
Jun 9, 2017

Conversation

woutersamaey
Copy link
Contributor

@woutersamaey woutersamaey commented Jun 9, 2017 •
edited

Description

Improved error logging for 2 cases:

  • The original exception was not passed as $cause in the new exception, when
  • The original exception is not logged sometimes when trying to save a product
    Now we can easily know the underlying exception.

Fixed Issues (if relevant)

None. General improvement

Manual testing scenarios

None. General improvement

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 9, 2017 •
edited

CLA assistant check
All committers have signed the CLA.

@ishakhsuvarov ishakhsuvarov self-assigned this Jun 9, 2017
@ishakhsuvarov ishakhsuvarov added this to the June 2017 milestone Jun 9, 2017
@woutersamaey woutersamaey changed the title Improved error logging: original exception was not passed as $cause Improved error logging when trying to save a product Jun 9, 2017
@magento-team magento-team merged commit fdb0c7f into magento:develop Jun 9, 2017
magento-team pushed a commit that referenced this pull request Jun 9, 2017
@ishakhsuvarov
MAGETWO-69780: Improved error logging: original exception was not pas…
198dcfd 
…sed as $cause #9890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
None yet
Projects
None yet
Milestone
June 2017
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@woutersamaey @magento-cicd2 @magento-team @ishakhsuvarov