-
Notifications
You must be signed in to change notification settings - Fork 0
Apply PaperMod-inspired styling and theme toggle #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a complete design system overhaul with PaperMod-inspired styling, introduces a functional light/dark theme toggle, and optimizes asset loading. The changes transform the site from a single-theme layout to a modern, accessible design system with proper theme management.
- Comprehensive CSS rewrite with new design tokens and modern card-based layouts
- Interactive theme toggle with system preference detection and persistent storage
- Conditional MathJax loading and streamlined head/footer structure
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| assets/css/styles.css | Complete styling overhaul with design tokens, theme variables, and modern layout components |
| _includes/head.html | Added theme initialization script, conditional MathJax loading, and theme-aware meta tags |
| _includes/footer.html | Implemented theme toggle functionality and removed duplicate MathJax script |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| a:hover, | ||
| a:focus { | ||
| color: var(--accent-strong); | ||
| color: #1d4ed8; |
Copilot
AI
Oct 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard-coded color value should use a CSS custom property instead. Consider using var(--color-accent-hover) or similar for consistency with the design token system.
| color: #0f172a; | ||
| padding: 0.75rem 1.5rem; | ||
| background: var(--color-accent); | ||
| color: #ffffff; |
Copilot
AI
Oct 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard-coded color value should use a CSS custom property. Consider defining --color-white: #ffffff in the root for consistency.
| transition: transform 0.2s ease, box-shadow 0.2s ease; | ||
| border: 1px solid transparent; | ||
| background: var(--color-accent); | ||
| color: #ffffff; |
Copilot
AI
Oct 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard-coded color value should use a CSS custom property. Consider using the same --color-white variable suggested for other white color instances.
| <meta name="theme-color" content="#f8fafc" media="(prefers-color-scheme: light)"> | ||
| <meta name="theme-color" content="#0f172a" media="(prefers-color-scheme: dark)"> | ||
| <meta name="theme-color" content="#f8fafc"> |
Copilot
AI
Oct 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard-coded color values should reference the CSS custom properties defined in styles.css. Consider using the same values as --color-bg for consistency.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68f1c75993848328908df9a8c66dcbd5