Skip to content

Refactor error handling and simplify graph processing #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magic5644 merged 5 commits into from
Feb 18, 2025
Merged

Refactor error handling and simplify graph processing #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d86df14
refactor: introduce custom exception classes for improved error handl…
glebournault Feb 18, 2025
a7ce1dd
refactor: simplify node and edge extraction, enhance degree calculati…
glebournault Feb 18, 2025
237ccf0
refactor: remove unused UnflattenGraph method and related logic in De…
glebournault Feb 18, 2025
cb348bf
refactor: remove unused GraphvizUnflattenOptions class in DependencyG…
glebournault Feb 18, 2025
543c303
refactor: use nameof operator for argument name in exception throwing
glebournault Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
119 changes: 44 additions & 75 deletions CodeLineCounter.Tests/CodeAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,123 +4,92 @@

namespace CodeLineCounter.Tests
{
public class CodeAnalyzerTests
public class CodeAnalyzerTests : TestBase
{
private readonly TextWriter _originalConsoleOut;

public CodeAnalyzerTests()
{
_originalConsoleOut = Console.Out;
}

[Fact]
public void TestAnalyzeSolution()
{
using (StringWriter consoleOutput = new())
{
Console.SetOut(consoleOutput);

string basePath = FileUtils.GetBasePath();
var solutionPath = Path.GetFullPath(Path.Combine(basePath, "..", "..", "..", "..", "CodeLineCounter.sln"));

// Act
var (metrics, projectTotals, totalLines, totalFiles, duplicationMap, dependencies) = CodeMetricsAnalyzer.AnalyzeSolution(solutionPath);

// Assert
Assert.NotNull(metrics);
Assert.NotEmpty(metrics);
Assert.NotEmpty(projectTotals);
Assert.NotEqual(0, totalLines);
Assert.NotEqual(0, totalFiles);
Assert.NotNull(duplicationMap);
Assert.NotNull(dependencies);
}
// Reset console output
Console.SetOut(_originalConsoleOut);

string basePath = FileUtils.GetBasePath();
var solutionPath = Path.GetFullPath(Path.Combine(basePath, "..", "..", "..", "..", "CodeLineCounter.sln"));

// Act
var (metrics, projectTotals, totalLines, totalFiles, duplicationMap, dependencies) = CodeMetricsAnalyzer.AnalyzeSolution(solutionPath);

// Assert
Assert.NotNull(metrics);
Assert.NotEmpty(metrics);
Assert.NotEmpty(projectTotals);
Assert.NotEqual(0, totalLines);
Assert.NotEqual(0, totalFiles);
Assert.NotNull(duplicationMap);
Assert.NotNull(dependencies);

}

[Fact]
public void AnalyzeSourceCode_Should_Set_CurrentNamespace()
{
using (StringWriter consoleOutput = new())
{
Console.SetOut(consoleOutput);

// Arrange
var projectNamespaceMetrics = new Dictionary<string, int>();
var lines = new string[]
{
// Arrange
var projectNamespaceMetrics = new Dictionary<string, int>();
var lines = new string[]
{
"namespace MyNamespace",
"{",
" // Code goes here",
"}"
};

// Act
CodeMetricsAnalyzer.AnalyzeSourceCode(projectNamespaceMetrics, lines, out string? currentNamespace, out _, out _);
};

// Assert
Assert.Equal("MyNamespace", currentNamespace);
// Act
CodeMetricsAnalyzer.AnalyzeSourceCode(projectNamespaceMetrics, lines, out string? currentNamespace, out _, out _);

}
// Reset console output
Console.SetOut(_originalConsoleOut);
// Assert
Assert.Equal("MyNamespace", currentNamespace);

}

[Fact]
public void AnalyzeSourceCode_Should_Set_FileLineCount()
{
using (StringWriter consoleOutput = new())
{
Console.SetOut(consoleOutput);

// Arrange
var projectNamespaceMetrics = new Dictionary<string, int>();
var lines = new string[]
{
// Arrange
var projectNamespaceMetrics = new Dictionary<string, int>();
var lines = new string[]
{
"namespace MyNamespace",
"{",
" // Code goes here",
"}"
};
};

// Act
CodeMetricsAnalyzer.AnalyzeSourceCode(projectNamespaceMetrics, lines, out _, out int fileLineCount, out _);
// Act
CodeMetricsAnalyzer.AnalyzeSourceCode(projectNamespaceMetrics, lines, out _, out int fileLineCount, out _);

// Assert - 3 lines only because comment lines are ignored
Assert.Equal(3, fileLineCount);
}
// Reset console output
Console.SetOut(_originalConsoleOut);
// Assert - 3 lines only because comment lines are ignored
Assert.Equal(3, fileLineCount);

}

[Fact]
public void AnalyzeSourceCode_Should_Set_FileCyclomaticComplexity()
{
using (StringWriter consoleOutput = new())
{
Console.SetOut(consoleOutput);

// Arrange
var projectNamespaceMetrics = new Dictionary<string, int>();
var lines = new string[]
{
// Arrange
var projectNamespaceMetrics = new Dictionary<string, int>();
var lines = new string[]
{
"namespace MyNamespace",
"{",
" // Code goes here",
"}"
};
};

// Act
CodeMetricsAnalyzer.AnalyzeSourceCode(projectNamespaceMetrics, lines, out _, out _, out int fileCyclomaticComplexity);
// Act
CodeMetricsAnalyzer.AnalyzeSourceCode(projectNamespaceMetrics, lines, out _, out _, out int fileCyclomaticComplexity);

// Assert
Assert.Equal(1, fileCyclomaticComplexity);
}
// Reset console output
Console.SetOut(_originalConsoleOut);
// Assert
Assert.Equal(1, fileCyclomaticComplexity);

}

Expand Down
Loading
Loading